add readme v1 #48
Open
add readme v1 #48
+25,194
−4,986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kishimoto96
requested review from
Shrreya,
algiknr,
halitbatur,
ZuluNovember and
ibraheemhajjar
Open
|
@Kishimoto96 Overall this looks good, but I'll review it after all other PRs are merged. In case something needs to be updated here on the documentation based on other PRs. Others just a tip for reviewing this PR - Open the readme branch and look at the rendered readme, because reading the markdown file might be a bit tricky. |
Shrreya
approved these changes
Mar 2, 2022
|
@Kishimoto96 can you merge this to main, fix conflicts and then it's ready to be merged. |
halitbatur
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add readme file, please take a look and give me your feedback as usual