Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I've been observing your project for a long time, but only recently had time for any significant contribution. I noticed that REGoth completely lacks video playing capability for in-game clips and decided to try to fill in the gap.
This patchset implements the basic video playing capability. The functionality is pretty straightforward: when an appropriate Daedalus function is triggered, the video player kicks in and play the clip.
Some more details:
To decode the videos (they use BINK format), I use ffmpeg. I added it to the libraries - it's configured to build the necessary parts only (bink decoders, demuxer and the file access layer) to minimize the compilation time and the size of the binary. Only Linux is supported as of now.
Only video is played. There's no audio support ATM. I don't really know how to integrate it with the existing audio system - any advice?
Keyboard control is limited to the cancelling the sequence with the ESC key. The original game had (if my memory serves me correctly) an extended video control option in the config file - does it make sense to implement this?
Tested with intro and credit videos from G1&2. (In G2, the main intro doesn't show up during the new game loading, but later DNDR-Intro does - I don't remember if the original game did it as well).
I'm looking forward for feedback, especially regarding the architectural decisions and aforementioned matter of the integration with the existing audio system.
BR, Mariusz