Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CSS Selectors to websites and made scraping code slightly mor… #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhchang
Copy link

@jhchang jhchang commented Jul 25, 2020

…e robust.

I changed the html parser to html5lib, since I noticed html.parser was having quite some difficulty parsing certain articles. I also updated some CSS selectors for reuters.com and and oreilly.com because the original code had css selectors that did not select the right elements because website layout probably have changed since this code was last updated.

I noticed a few articles had some body text split up into multiple children to represent the paragraphs. So I made changes so the code loops through the children text instead of just the first child.

This is my first pull request and appreciate any feedback. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant