Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeat frames #24

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Fix repeat frames #24

merged 5 commits into from
Mar 25, 2024

Conversation

LandryNorris
Copy link
Contributor

Frames previously were not properly repeating. This PR should fix that. Tested with the following js program

CanBridge.sendCANMessage(descriptor, 0xCBA321, [0x12, 0x34, 0x56, 0x78], 150)

await new Promise((resolve) => setTimeout(resolve, 2000));

CanBridge.sendCANMessage(descriptor, 0xCBA321, [0x34, 0x56, 0x78, 0x12], 150)

await new Promise((resolve) => setTimeout(resolve, 2000));

CanBridge.sendCANMessage(descriptor, 0xCBA321, [0x34, 0x56, 0x78, 0x12], 100)

await new Promise((resolve) => setTimeout(resolve, 2000));

CanBridge.sendCANMessage(descriptor, 0xCBA321, [0x34, 0x56, 0x78, 0x12], 0)

@NoahAndrews NoahAndrews linked an issue Mar 25, 2024 that may be closed by this pull request
@LandryNorris LandryNorris merged commit 8316a1f into main Mar 25, 2024
1 check passed
@LandryNorris LandryNorris deleted the fix/repeat-frames branch March 25, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Repeating Frames
2 participants