Feature/additional analog inputs #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LandryNorris
commented
Jun 26, 2023
| } | ||
| } else { | ||
| let value = await hubs[0].getAnalogInput(channel); | ||
| export async function analog(hub: ExpansionHub, channel: number, continuous: boolean) { |
There was a problem hiding this comment.
I converted these methods from having an if check for whether to use a while (with annoying code duplication) into a while loop with a conditional break at the end (which is slightly less readable in my opinion). Between these two options, I prefer the second, but I'm open to alternatives. I could create a maybeWhile(continuous: boolean, block: () => void) and use that.
LandryNorris
commented
Jun 27, 2023
| hub.close(); | ||
| }); | ||
|
|
||
| program | ||
| .command("servo <channel> <pulseWidth> [frameWidth]") | ||
| .description("Run a servo with pulse width and optional frame width") | ||
| .action(async (channel, pulseWidth, frameWidth) => { | ||
| runOnSigint(async () => { |
There was a problem hiding this comment.
I moved these because the hub wasn't semantically declared before this. It's very unlikely to cause any issues (unless we get a sigint before it finishes opening the hub).
NoahAndrews
requested changes
Jun 27, 2023
Co-authored-by: Noah Andrews <[email protected]>
NoahAndrews
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #84
Adds remaining analog inputs not added in #58