Skip to content

dist/tools/compile_test: specify toolchain and exit code [backport 2025.04] #21540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2025
Merged

dist/tools/compile_test: specify toolchain and exit code [backport 2025.04] #21540

merged 2 commits into from
Jun 5, 2025

Conversation

mguetschow
Copy link
Contributor

Backport of #21534

Contribution description

This PR changes dist/tools/compile_test/compile_like_murdock.py to

  1. allow specifying the used toolchain (hardcoded to gnu (backwards-compatible default) and llvm)
  2. return an error code on exit if any of the builds failed (this is a breaking change as it was before always returning success)

Testing procedure

Let's hope no other tool was relying on the exit code being always zero, hopefully CI would catch that.

You can test the script locally with

dist/tools/compile_test/compile_like_murdock.py -a tests/pkg/fff tests/sys/shell -b native32 -t gnu
dist/tools/compile_test/compile_like_murdock.py -a tests/pkg/fff tests/sys/shell -b native32 -t llvm

The first should succeed, the latter fail.

Issues/PRs references

This is needed for RIOT-OS/riotdocker#256 and transitively to unblock the failing CI tests. Will need to be backported to the last release.

@mguetschow mguetschow added Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation labels Jun 5, 2025
@mguetschow mguetschow mentioned this pull request Jun 5, 2025
Merged
@mguetschow mguetschow requested review from crasbe and maribu June 5, 2025 07:40
@riot-ci
Copy link

riot-ci commented Jun 5, 2025

Murdock results

✔️ PASSED

af20537 dist/tools/compile_test: error exit code on any failed build

Success Failures Total Runtime
1 0 1 01m:43s

Artifacts

@crasbe crasbe added this pull request to the merge queue Jun 5, 2025
Merged via the queue into RIOT-OS:2025.04-branch with commit 3bc4dc7 Jun 5, 2025
30 of 31 checks passed
@mguetschow mguetschow deleted the backport/2025.04/compile-test-like-former-buildtest branch June 5, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crasbe crasbe crasbe approved these changes

@maribu maribu Awaiting requested review from maribu

Assignees
No one assigned
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mguetschow @riot-ci @crasbe