Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding - first part #114

Closed
wants to merge 16 commits into from
Closed

Onboarding - first part #114

wants to merge 16 commits into from

Conversation

mene412
Copy link

@mene412 mene412 commented Aug 15, 2023

Issue #39
TODO:

  • Make the onboarding page visible only on the first visit.
  • Connect the "ADD BUDGET" feature and the account_setup.dart page with the database.
  • Validate the presence of data when the "START TRACKING YOUR EXPENSES" button is pressed.

mene412 and others added 12 commits February 21, 2023 11:47
@mene412
Update pubspec.lock
8f3952d
@mene412
Merge branch 'main' of https://github.com/mene412/sossoldi
349be48
@mene412
Merge branch 'main' of https://github.com/mene412/sossoldi
fa29fbd
@mene412
First part of onboarding
2da950a
@mene412
First part of onboarding
55f7d69 
[Figma reference](https://www.figma.com/file/6NyY9yqunpbU7HIkbNEAL3/Sossoldi-App?type=design&node-id=1163-4030&t=NgwAP2DuLag5D9oN-0)
DONE (copying by 0xbaggi and updating with `style.dart` and `constant.dart`):
* "start the set up" page
* step 1 page (set budgets)
   * Scrollable list of selectable budgets (taken from the database) as a grid of cards
   * "add category" card
   * Numeric keyboard for adding the budget
* step 2 page (set liquidity)
   * Input fields for account name and amount (with only number keyboard)
TODO:
* Show onboarding page only the first time
* Implement the updating of the database when adding budget and account
* Implement "Edit Icon and Color" when creating an account
@mene412
Removed useless code
b4d9db4
@mene412
Code divided in widget for a better readability
bcc186c
@mene412
First try for using providers for budgets
bfa5f07
@mene412
Merge branch 'RIP-Comm:main' into main
aebb808
@mene412
UI update
dae4775 
- Update the keyboard for entering the budget.
- Update the "EDIT ICON AND COLOR" section in `account_setup.dart`.

TODO:
- Make the onboarding page visible only on the first visit.
- Connect the "ADD BUDGET" feature and the `account_setup.dart` page with the database.
- Validate the presence of data when the "START TRACKING YOUR EXPENSES" button is pressed.
@mene412
Merge branch 'RIP-Comm:main' into main
9e6788e
@mene412
Merge pull request #1 from mene412/onboarding
dcd5f7d 
Onboarding - first part
@FedericoBruzzone FedericoBruzzone marked this pull request as ready for review September 11, 2023 21:46
@theperu
Copy link
Collaborator

theperu commented Dec 5, 2023

Hi @mene412! Do you think that you could also work on the parts that you pointed out are missing in order to complete this feature? In that case we might want to keep this open

@mene412
Copy link
Author

mene412 commented Dec 5, 2023

Up to today, I am unable to proceed because a part of the provider is missing, specifically budgets_provider.dart, in order to add the budgets. I tried to modify the file, but I haven't reached a solution yet.

@theperu
Copy link
Collaborator

theperu commented Dec 6, 2023

@mikev-cw and @lucaantonelli what do you think? Do we want to merge this now or you have suggestions/time to help mene on the next steps?

@mikev-cw
Copy link
Collaborator

mikev-cw commented Dec 11, 2023 •
edited
Loading

I see that this was originally a draft PR, converted to ready for review, then approved, for reasons I personally don't see. Now has even unresolved conflicts.
So I don't think this is ready to merge: Onboarding is a critical and primary feature that needs to be as ready as possible to merge (also to not hinder development, imagine having to do an onboarding that doesn't work every time the app is launched).
So @mene412 if there's something missing, as budget provider you mentioned, tell us if you can work on it, or you need someone else to help. Whatever the case, i think we should put this into an issue.

EDIT: If we want to merge something that's intentionally not finished (like skipping the budget feature), it's ok, but I think we should let developers force start the onboarding when they need

@mikev-cw mikev-cw marked this pull request as draft December 11, 2023 13:42
@theperu theperu closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedericoBruzzone FedericoBruzzone Awaiting requested review from FedericoBruzzone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mene412 @theperu @mikev-cw @FedericoBruzzone