-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update faq #3596
Update faq #3596
Conversation
98f9599
to
73814d1
Compare
fdb0996
to
0d53bfd
Compare
This means you can compile host code with the compiler of your choice and link the | ||
generated host object code with device code. | ||
|
||
Can HIP applications be compiled with a C compiler? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably we should add these here:
https://advanced-micro-devices-demo--3622.com.readthedocs.build/projects/HIP/en/3622/understand/compilers.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have to rebase on top of that. Let's wait until either is merged in and add it to the other one
docs/faq.rst
Outdated
Miscellaneous | ||
============= | ||
|
||
How to create a guard for code that is specific to the host or the GPU? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in the porting guide and we should link here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this does not (only) belong to the porting guide, this is also relevant for other users. So either the programming guide, the compilers. I'd vote for the compilers or somewhere where we explain the compilation process.
Compiler related questions | ||
========================== | ||
|
||
How to use HIP-Clang to build HIP programs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link this tutorial: https://rocm.docs.amd.com/projects/HIP/en/latest/tutorial/saxpy.html#compiling-on-the-command-line
It is written to represent the compiler usage on different OS or platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of whether to even keep this question in the FAQ. That tutorial is a bit overkill for this question. Maybe something similar can also be added to the HIP compilers page of #3622 and we could link to that
bc6184e
to
50931d5
Compare
docs/faq.rst
Outdated
The supported operating systems are listed in the | ||
:doc:`rocm:compatibility/compatibility-matrix`. | ||
|
||
CUDA and OpenCL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tittle should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it. Removing it would expand the dynamic table of contents on the right side too much, and it's also not directly related to "HIP support"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Is HIP a drop-in replacement for CUDA? | ||
-------------------------------------- | ||
|
||
The `HIPIFY <https://github.com/ROCm/HIPIFY>`_ tools can automatically convert |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HIP applications can be used on both AMD platform and non-AMD platform, like NVIDIA, using the conversion tool HIPIFY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic is backwards - CUDA code can be ported to the (portable) HIP code using HIPIFY. Also the question itself already implies, that the code can also run on NVIDIA platforms.
docs/faq.rst
Outdated
|
||
HIP detected my platform incorrectly. What should I do? | ||
------------------------------------------------------- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this question, I think the original explanation is better. User needs to know how to differentiate the platform, not how to port the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal for this PR is to reduce the amount of content duplication, so where possible it is preferred to link to existing documentation. I found a better explanation in the hipcc documentation
docs/faq.rst
Outdated
|
||
Miscellaneous | ||
============= | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a question need to add "Can I develop applications with HIP APIs on Windows the same on Linux?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that really a frequently asked question? What would the answer to that be?
FAQ looks good to me. |
2c942cc
to
d8b362f
Compare
Some unintended consequences of the Single backticks produce italics, instead of unformatted blocks. Here is an example - Also, these nested bullet points got messed up and rendered as a single line
(ref) |
No description provided.