Skip to content

[NFC] Remove dangerous vestigial noise #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexVlx wants to merge 6 commits into
base: amd-staging
Choose a base branch
from
Open

[NFC] Remove dangerous vestigial noise #186

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ccb720a
HIPSTDPAR fixes.
AlexVlx Apr 23, 2026
4a16671
Merge branches 'amd-staging' and 'alexv/fix_constexpr_gep' of https:/…
AlexVlx May 5, 2026
b5730e3
Undo accidental removal.
AlexVlx May 5, 2026
451bb50
Merge branch 'amd-staging' of https://github.com/ROCm/SPIRV-LLVM-Tran…
AlexVlx May 8, 2026
372aa6e
Remove vestigial noise.
AlexVlx May 8, 2026
ffd3464
Merge branch 'amd-staging' into alexv/fix_constexpr_gep
aobolensk Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lib/SPIRV/SPIRVWriter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,10 +856,6 @@ SPIRVType *LLVMToSPIRVBase::transScavengedType(Value *V) {
SPIRVEC_UnsupportedVarArgFunction);

SPIRVType *RT = transType(FnTy->getReturnType());
if (M->getTargetTriple().getVendor() == Triple::VendorType::AMD)
if (F->getReturnType()->isPtrOrPtrVectorTy())
RT = transType(F->getReturnType()->getWithNewType(
PointerType::get(F->getContext(), SPIRAS_Constant)));

std::vector<SPIRVType *> PT;
for (Argument &Arg : F->args()) {
Expand Down
Loading