hipsolver & rocsolver Test for the ROCK #1585
Conversation
| "timeout_minutes": 60, | ||
| "test_script": f"python {_get_script_path('test_hipsolver.py')}", | ||
| "platform": ["linux", "windows"], | ||
| "total_shards": 4, |
There was a problem hiding this comment.
based on the test logs, the tests take about 2 seconds per shard to run. Since the test time is so little, we don't need 4 shards. Better to do just 1
| "hipsolver": { | ||
| "job_name": "hipsolver", | ||
| "fetch_artifact_args": "--blas --tests", | ||
| "timeout_minutes": 60, |
There was a problem hiding this comment.
can you adjust the timeout minutes to correctly reflect the time tests take?
|
|
||
| logging.basicConfig(level=logging.INFO) | ||
|
|
||
| cmd = [f"{THEROCK_BIN_DIR}/hipsolver-test", "--gtest_filter=*float_complex*-*known_bug*"] |
There was a problem hiding this comment.
is this filter correct? I would reach out to SOLVER team to make sure this matches "presubmit"!
subodh-dubey-amd
changed the title
|
looks like tests are failing. we could enable these tests and add gtest ignore filters and link to these issues: [ci] SOLVER windows test errors for gfx1151 · Issue #1080 · ROCm/TheRock / [SWDEV-555871] [gfx1151/gfx942] [SOLVER] rocSOLVER and hipSOLVER test failures - INTERNAL |
| "timeout_minutes": 120, | ||
| "test_script": f"python {_get_script_path('test_rocsolver.py')}", | ||
| "platform": ["linux"], | ||
| "total_shards": 4, |
There was a problem hiding this comment.
The newly added rocsolver tests (I think this was hipsolver only when I last revied) still use 4 shards and have a 120 minute timeout. Is this needed? Otherwise please set lower values as for hipsolver. If a workflow hangs, it will otherwise block resources for 2 hours!
| sources/ | ||
| .vscode/ | ||
| *.venv | ||
| *venv |
There was a problem hiding this comment.
This is a reasonable change (had the same in mind earlier!) but should not be part of this PR. Please send a separate patch.
| /install/ | ||
| /output-*/ | ||
| /out/ | ||
| therock-build/* |
There was a problem hiding this comment.
As above. If desired (most folks use build), please send a separate PR.
Motivation
Add hipsolver & rocsolver to the ROC test suite to ensure comprehensive testing coverage for the ROCm linear algebra solver library and catch regressions early in the CI pipeline.
Technical Details
test_hipsolver.py&test_rocsolver.pyscript in test_executable_scriptsTest Plan
Test Result
hipsolver & rocsolver tests successfully integrated into CI pipeline with proper sharding and platform support.
Submission Checklist