Add SPDX License Identifiers and code clean up (#3)

* Clean up the code * Add SPDX License Identifiers to all source files
ROCm · Feb 14, 2024 · 2569660 · 2569660
1 parent a78e4d2
commit 2569660
Show file tree

Hide file tree

Showing 76 changed files with 338 additions and 184 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,3 +1,6 @@
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
+
 cmake_minimum_required(VERSION 3.18 FATAL_ERROR)
 
 project(AOTriton CXX C)

diff --git a/Makefile b/Makefile
diff --git a/README.md b/README.md
@@ -1,16 +1,18 @@
-## Usage
+## Build Instructions
 
 ```
 mkdir build
-python python/generate.py
-(cd build; make -j `nproc` -f Makefile.compile)
-python python/generate_shim.py
-(cd build; make -j `nproc` -f Makefile.shim)
+cd build
+cmake .. -DCMAKE_INSTALL_PREFIX=./install_dir
+# Use ccmake to tweak options
+make install
 ```
 
-Then the `attn_fwd.so` and `attn_fwd.h` can be found under `build/`
+The library and the header file can be found under `build/install_dir` afterwards.
+
+Note: do not run `make` separately, due to the limit of the current build
+system, `make install` will run the whole build process unconditionally.
 
 ### Prerequisites
 
-* `hipcc`
-* `triton`
+* `hipcc` in `/opt/rocm/bin`, as a part of [ROCm](https://rocm.docs.amd.com/projects/install-on-linux/en/latest/)
diff --git a/bindings/CMakeLists.txt b/bindings/CMakeLists.txt
@@ -1,3 +1,6 @@
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
+
 aux_source_directory(. PYAOTRITON_SRC)
 # find_package(hip REQUIRED)
 pybind11_add_module(pyaotriton ${PYAOTRITON_SRC})

diff --git a/bindings/hipruntime.cc b/bindings/hipruntime.cc
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 #include <aotriton/runtime.h>
 #include <pybind11/pybind11.h>
 namespace py = pybind11;

diff --git a/bindings/module.cc b/bindings/module.cc
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 #include <aotriton/dtypes.h>
 #include <aotriton/flash.h>
 #include <aotriton/runtime.h>

diff --git a/csrc/CMakeLists.txt b/csrc/CMakeLists.txt
@@ -1,3 +1,6 @@
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
+
 message("CMAKE_SOURCE_DIR ${CMAKE_SOURCE_DIR}")
 message("CMAKE_CURRENT_LIST_DIR ${CMAKE_CURRENT_LIST_DIR}")
 message("CMAKE_CURRENT_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}")

diff --git a/csrc/README.md b/csrc/README.md
@@ -0,0 +1,3 @@
+# Deprecated Content
+
+The code under this directory is deprecated, and will be removed in future releases.
diff --git a/csrc/aotriton_kernel.h b/csrc/aotriton_kernel.h
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 #ifndef AOTRITON_KERNEL_H
 #define AOTRITON_KERNEL_H
 

diff --git a/csrc/template/kernel_shim.cc b/csrc/template/kernel_shim.cc
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 #define INCBIN_PREFIX g_aotriton_kernel_for_shim_
 #define INCBIN_STYLE INCBIN_STYLE_SNAKE
 #include <incbin.h>

diff --git a/csrc/template/kernel_shim.footer.h b/csrc/template/kernel_shim.footer.h
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 }; // namespace aotriton::v1
 
 #endif
diff --git a/csrc/template/kernel_shim.header.h b/csrc/template/kernel_shim.header.h
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 #ifndef AOTRITON_{shim_kernel_name}_H
 #define AOTRITON_{shim_kernel_name}_H
 

diff --git a/include/aotriton/_internal/triton_kernel.h b/include/aotriton/_internal/triton_kernel.h
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 #ifndef AOTRITON_V2_API_TRITON_KERNEL_H
 #define AOTRITON_V2_API_TRITON_KERNEL_H
 

diff --git a/include/aotriton/dtypes.h b/include/aotriton/dtypes.h
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 #ifndef AOTRITON_V2_API_DTYPES_H
 #define AOTRITON_V2_API_DTYPES_H
 

diff --git a/include/aotriton/flash.h b/include/aotriton/flash.h
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 #ifndef AOTRITON_V2_API_FLASH_ATTN_H
 #define AOTRITON_V2_API_FLASH_ATTN_H
 

diff --git a/include/aotriton/runtime.h b/include/aotriton/runtime.h
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 #ifndef AOTRITON_V2_API_RUNTIME_H
 #define AOTRITON_V2_API_RUNTIME_H
 

diff --git a/include/aotriton/util.h b/include/aotriton/util.h
@@ -1,3 +1,6 @@
+// Copyright © 2023-2024 Advanced Micro Devices, Inc.
+// SPDX-License-Identifier: MIT
+
 #ifndef AOTRITON_V2_API_UTIL_H
 #define AOTRITON_V2_API_UTIL_H
 

diff --git a/python/README.md b/python/README.md
@@ -0,0 +1,3 @@
+# Deprecated Content
+
+The code under this directory is deprecated, and will be removed in future releases.
diff --git a/python/compile.py b/python/compile.py
diff --git a/python/compile.py b/python/compile.py
@@ -0,0 +1 @@
+../v2python/compile.py
diff --git a/python/generate.py b/python/generate.py
@@ -1,3 +1,6 @@
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
+
 import rules
 import io
 import shutil

diff --git a/python/generate_shim.py b/python/generate_shim.py
@@ -1,3 +1,6 @@
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
+
 import rules
 import io
 import shutil

diff --git a/python/kernel_desc.py b/python/kernel_desc.py
@@ -1,4 +1,6 @@
 #!/usr/bin/env python
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
 
 from abc import ABC, abstractmethod
 from pathlib import Path

diff --git a/python/object_desc.py b/python/object_desc.py
@@ -1,4 +1,6 @@
 #!/usr/bin/env python
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
 
 from pathlib import Path
 import json

diff --git a/python/rules.py b/python/rules.py
@@ -1,3 +1,6 @@
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
+
 from kernel_desc import KernelDescription, get_possible_types
 
 def _pattern(arguments, prefix):

diff --git a/test/aotriton_flash.py b/test/aotriton_flash.py
@@ -1,3 +1,6 @@
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
+
 from pyaotriton.v2.flash import attn_fwd as fa_forward, attn_bwd as fa_backward
 from pyaotriton import T1, T2, T4, DType, Stream
 

diff --git a/test/attn_torch_function.py b/test/attn_torch_function.py
@@ -1,4 +1,6 @@
 #!/usr/bin/env python
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
 
 import torch
 from aotriton_flash import attn_fwd, attn_bwd

diff --git a/test/bwd_preprocess.py b/test/bwd_preprocess.py
@@ -1,4 +1,6 @@
 #!/usr/bin/env python
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
 
 """
 Fused Attention

diff --git a/test/bwd_split_kernel.py b/test/bwd_split_kernel.py
@@ -1,4 +1,6 @@
 #!/usr/bin/env python
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
 
 """
 Fused Attention

diff --git a/test/fwd_kernel.py b/test/fwd_kernel.py
@@ -1,4 +1,6 @@
 #!/usr/bin/env python
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
 
 """
 Fused Attention

diff --git a/test/test_backward.py b/test/test_backward.py
@@ -1,4 +1,6 @@
 #!/usr/bin/env python
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
 
 import pytest
 import torch

diff --git a/test/test_forward.py b/test/test_forward.py
@@ -1,4 +1,6 @@
 #!/usr/bin/env python
+# Copyright © 2023-2024 Advanced Micro Devices, Inc.
+# SPDX-License-Identifier: MIT
 
 import pytest
 import torch