Respect CMAKE_PLATFORM_NO_VERSIONED_SONAME when installing libraries. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I9d65880e129eacaa5f3971332a9e1374d1878c9e
Change-Id: Ia9ec1705ce72c025d5ea75f4df56b0988c6f103d
Change-Id: I0a0814d335e8c3d9a80c1217d8d2df62e7baa548
Change-Id: Ia451c84750d33c96c2a435469694794d78fb2725
Change-Id: Ib6b00b7ab1f51fd6d1ea4a6e3d3027d71a0ce63d
For last mainline promotion based on 15-May-2023 build. Change-Id: Ia2381211df6807df1c8cb265a625c726cd7ab290
Change-Id: I7f5c5e85e6c6bfd05f057350b02f73d03495571b
Change-Id: Ic3916acc6706444717b0c520ed5056e78a76505f
Change-Id: I3279d1c48704e040338bf83debc0588cd90841ee
Change-Id: I85fef1bdc27aea2350ad36184625ebcf3c971c51
Change-Id: I7542839da03d0fe8fb41683acec3a3416716aa57
Change-Id: Ia4fb1f59720c62fc872c0ed7cc4e8625353d7079
Change-Id: Ib6f4af31ac7049997d9f00eafc359846315efa1c
Change-Id: I0bb923950f814052f51d15d59fabaa2cafd679a9
Change-Id: Ib120768cedac894e5fdcb84daff55a8cde8a7167
Change-Id: Icc81cb530ffd2ed10daf1c3cbf4c973ec9ab67f1
Change-Id: I9dc0c086af6c3482001908e3ccfd984ee0d8c420
Change-Id: I7a99a04040e1e1de4f1c9d7ea6e06302f03d5f26
Change-Id: Ib54546e366b61bdb83789d8264f30f1bfb875605
Change-Id: I6c41f8497564e1d718a3b5bc09c45ec4b53fd25f
Signed-off-by: sdashmiz <[email protected]> Change-Id: Id9de54b4fd1be7b6b887a4ebfcc6a3d9a70c7bc9 (cherry picked from commit 2d83aba)
Change-Id: Idc9e07e9422f5cbc71eb697f11c89051abcefa29
- hipArray will be an internal struct from rocm6.0 Signed-off-by: sdashmiz <[email protected]> Change-Id: Icf97fe96b87be8532098cd7f9ceaad099f99c9b9
Signed-off-by: sdashmiz <[email protected]> Change-Id: Ie58d16420578e7118997eb40a9fd6a6641b666f3
Change-Id: Ic0082d3960aadbb7ac559141b6e84bd29a75b5cd
…usage Compiler seem to be stricter in compiler staging builds related to safe buffer programming when compared to other component staging builds. This seem to result in additional errors when -Werror is enabled in MIGraphX tests. Removes all the clang pragmas to ignore several type of warnings in all the headers and adds a single pragma which ignores all warnings using Change-Id: I95f302bb285b2451b19dd5dfdb7df29164b0f750 (cherry picked from commit b5d286a)
__smid() needs to use both HW_ID and XCC_ID for gfx940, gfx941, and gfx942. Previously, we only did this for gfx940 and thus XCC_ID was incorrectly not passed back on the other two architectures. Change-Id: I9fb13b6cef3280e15463443a180174629d03f8b2
Change-Id: I4d2c8cc5a8d34d9f7d4a92ff11ff36d756d019d5
…/surface/device capabilities device struct entries - alias hipGetDeviceProperties to hipGetDevicePropertiesR0600 - alias hipDeviceProp_t to hipDeviceProp_tR0600 - remove gcnArch from new device property struct - add new requested struct members Change-Id: If3f5dbef3d608487d9f6f419285f4bf577ea9bf0
Change-Id: I95d0d7aec802cc35bc754a70be5f41cb80c393a8
Change-Id: Ia05e09bd10ab623b36c74037e9988e132120dd9f
Change-Id: I7c8ce3c1b8cb11e0253b0f51ae10fca7f0a32017 (cherry picked from commit 7150b2e)
Change-Id: I50e1ef00e6ecd23a6fb2e2eaaf298a479c5d3501
...before we dereference it. It might have been deleted. Change-Id: Ief832ee0907658a40ca42b9d78d19658153a05dd
…test failure Add clang pragma push and pop diagnostics for ignoring "-Weverything" in the hiprtc builtins header. Otherwise this will ignore even the geniune errors occurring in the hiprtc kernels. Change-Id: I8c3dacf902732b2ea495d83e797369f8aebd75d6 (cherry picked from commit 912cc40)
This is not the best fix because it is manually installing platform specific shared library names/symlinks. However, I don't wish to be on the hook for validating historical practices without a public CI. A better approach would be to install the CMake targets and let CMake do the right thing.
stellaraccident
requested review from
gargrahul,
mangupta and
rakesroy
as code owners
|
@stellaraccident : Thanks for submitting the patch for review. Can you please rebase this patch on top of current develop branch? I see too many unrelated commits/files modified as well as merge conflicts for this patch. It would make it harder to review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect CMAKE_PLATFORM_NO_VERSIONED_SONAME when installing libraries.
This is not the best fix because it is manually installing platform specific shared library names/symlinks. However, I don't wish to be on the hook for validating historical practices without a public CI. A better approach would be to install the CMake targets and let CMake do the right thing.