Skip to content

Conversation

kylasa
Copy link
Contributor

@kylasa kylasa commented Sep 16, 2025

Proposed changes

Due the changes in the recent past couple of weeks the functionality of the V5 pipeline is broken.
Fixing this issue with these proposed code changes.

Following issues were identified and addressed with these code changes.

  1. "NumWaveGroups" variable was incorrect.
  2. BlockSize was calculated incorrectly in the CShuffle epilogue operation. Introducing the K dimension warps when computing the block size.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@illsilin
Copy link
Collaborator

Can you please actually describe the changes?

@illsilin
Copy link
Collaborator

And run clang-format before creating the PR?

@kylasa
Copy link
Contributor Author

kylasa commented Sep 16, 2025

PR updated with the commit with the clang formatting changes.

@kylasa kylasa requested a review from cgmillette as a code owner September 26, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants