ci(spirv): build rocThrust for the rocm-examples job - #3633
Merged
Conversation
Applications/monte_carlo_pi migrated off the CUB-style hipcub iterators that CCCL 3.0 removed to portable thrust:: iterators (rocm-examples #493), which pulls in a rocThrust dependency. Add a rocThrust checkout + install into the staging tree so the rocm-examples build can find it. Header-only, so it's a fast configure + install matching the hipCUB step. Changes: - Add ROCTHRUST_BUILD env var. - Checkout ROCm/rocThrust@develop, configure + install into staging after hipCUB. - Include the build dir in the strip + tar steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Applications/monte_carlo_piwas migrated off the CUB-style hipcub iterators that CCCL 3.0 removed (ROCm/rocm-libraries#9931) to the portablethrust::iterators — see ROCm/rocm-examples#493. That migration pulls in a rocThrust dependency (find_package(rocthrust REQUIRED)), which the SPIRV CI build job doesn't currently install, so theTest rocm-examplesjob would fail at configure withCould not find rocthrust.What
Add a rocThrust checkout + install into the staging tree so the rocm-examples build can find it:
ROCTHRUST_BUILDenv var.ROCm/rocThrust@develop, configure + install into staging after hipCUB. rocThrust is header-only, so it's a fast configure + install, mirroring the hipCUB step.Ordering
The
Test rocm-examplesjob stays red until both this and rocm-examples#493 land (either order); then the nextamd-stagingrun goes green. The job is informational (not a required check), so this doesn't block merges in the meantime.