-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation error with ALICE #645
Open
NB4444
wants to merge
144
commits into
ROCm:develop
Choose a base branch
from
StreamHPC:fix-alice-compile-upstream
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+16,161
−2,659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erate header file
- Simplified adjacent_find_impl functor definition - Added test for indirect_iterator
…nged all std::numeric_limits to test_utils::numeric_limits
… and custom_test_type<double>
Co-authored-by: Beatriz Navidad Vilches <[email protected]>
NB4444
requested review from
a team,
stanleytsang-amd,
umfranzw,
RobsonRLemos and
lawruble13
as code owners
November 15, 2024 13:35
spolifroni-amd
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all commits from #631. That PR should be merge before this one.
This commit adds 2 commits to fix compilation errors when building with ALICE.