Skip to content

Conversation

Ruturaj4
Copy link
Contributor

@i-chaochen bump xla on master.

Copy link
Contributor

@psanal35 psanal35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@i-chaochen
Copy link

i-chaochen commented Aug 12, 2025

@i-chaochen fixed!

@Ruturaj4 Ruturaj4 changed the title bump up xla according to chao's request bump up xla version Aug 12, 2025
@charleshofer
Copy link
Collaborator

charleshofer commented Aug 12, 2025

Same as other PR. Linking to tickets or explain why this change is needed takes like two minutes of time and will potentially save hours months from now.

@Ruturaj4
Copy link
Contributor Author

@charleshofer it is xla team's request to update the pinned commit to the latest.

@charleshofer
Copy link
Collaborator

Okay, but why are they requesting this? What does this change or fix and why are those changes necessary? Imagine yourself 3 months from now looking back at this PR. What type of information would you want to know right away if you suspect that this PR introduced a bug or a specific feature? The person or team who requested it probably isn't that important, but why they thought it was important is. That's the type of info that's helpful in commit comments.

@charleshofer
Copy link
Collaborator

I realize this it's nit-picky, but in my experience, consistently having good comments makes future development easier.

Here's an example of a pretty good one: #50. It's super clear from the comment that the change adds a patch file that changes the installed jaxlib, that we need this change to fix hipsolver unit tests when using the plugin, and it gets bonus points for reminding future developers of what they need to do if they move the file that the PR adds.

@i-chaochen
Copy link

i-chaochen commented Aug 18, 2025

I agree @charleshofer about the commit message, bump up xla according to chao's request this is sloppy...don't put my name on it and don't edit my message, please.

As a side note, I notice that seems this rocm-jax:master targeting xla0-0.6, just to be aware 0.6 is still WIP and many features WIP, and XLA commit already included all info: ROCm/xla#308

@gulsumgudukbay
Copy link
Contributor

@Ruturaj4 is this PR outdated? If so, please close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants