Skip to content

[hipblaslt] allow skipping kernel launch for matrix initialization #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[hipblaslt] allow skipping kernel launch for matrix initialization #1431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions projects/hipblaslt/clients/common/src/hipblaslt_init_device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@
#include "hipblaslt_test.hpp"
#include <hipblaslt/hipblaslt.h>

#include <Tensile/Debug.hpp>

template <typename T, typename F>
__global__ void fill_kernel(T* A, size_t size, size_t offset, F f)
{
Expand Down Expand Up @@ -126,6 +128,12 @@ void hipblaslt_init_device(ABC_dims abc,
size_t stride,
size_t batch_count)
{
if(TensileLite::Debug::Instance().skipKernelLaunch())
{
std::cout << "DEBUG: Skip execution of kernel for matrix initialization" << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reason why you would want to skip GEMM kernel execution (both with TENSILE_DB2=0x1). Perhaps for testing host code when a specific GPU is not available. This was requested by @bethune-bryant

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use TensileLite::Debug outside tensilelite.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tensile runtime env shouldn't be used by hipblaslt-bench tool. Don't mix those up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not?

return;
}

if(is_nan)
{
std::array<T, 100> rand_nans;
Expand Down