feat(hipcub): Add CCCL 3.0.x support by matyas-streamhpc · Pull Request #4079 · ROCm/rocm-libraries

matyas-streamhpc · 2026-01-26T16:31:14Z

Add CCCL 3.0.x support for hipCUB library.

Additional updates: fix CUB backend

JIRA ID : EXSWSTRHPC-300

stanleytsang-amd · 2026-02-27T21:00:33Z

There are merge conflicts and it looks like the RadixSort 4g test is still failing as well as DeviceMerge. Rerunning CI to make sure it isn't a flaky CI problem, but perhaps the RadixSort test fix is not quite there yet.

stanleytsang-amd · 2026-03-02T15:48:52Z

@matyas-streamhpc RadixSort 4G test is timing out on Windows + gfx1151

47/47 Test #23: hipcub.DeviceRadixSort ............***Timeout 305.22 sec
Running main() from B:\build\third-party\googletest\source\googletest\src\gtest_main.cc
[==========] Running 126 tests from 32 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from HipcubDeviceRadixSort
[ RUN ] HipcubDeviceRadixSort.SortKeysOver4G

Also please resolve the merge conflicts, I am unable to run math-ci until then.

matyas-streamhpc · 2026-03-09T08:52:29Z

@matyas-streamhpc RadixSort 4G test is timing out on Windows + gfx1151

47/47 Test #23: hipcub.DeviceRadixSort ............***Timeout 305.22 sec Running main() from B:\build\third-party\googletest\source\googletest\src\gtest_main.cc [==========] Running 126 tests from 32 test suites. [----------] Global test environment set-up. [----------] 2 tests from HipcubDeviceRadixSort [ RUN ] HipcubDeviceRadixSort.SortKeysOver4G

Also please resolve the merge conflicts, I am unable to run math-ci until then.

I rebased the branch and I added the fix for Windows. The CI job is passing for Windows now.

codecov-commenter · 2026-03-19T02:47:03Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #4079       +/-   ##
============================================
- Coverage    67.26%   39.04%   -28.22%     
============================================
  Files         1844      152     -1692     
  Lines       284014    25692   -258322     
  Branches     39839      567    -39272     
============================================
- Hits        191037    10031   -181006     
+ Misses       76518    15284    -61234     
+ Partials     16459      377    -16082

Flag	Coverage Δ
hipBLAS	`?`
hipBLASLt	`?`
hipCUB	`?`
hipDNN	`?`
hipFFT	`?`
hipRAND	`?`
hipSOLVER	`?`
hipSPARSE	`?`
rocBLAS	`?`
rocFFT	`?`
rocPRIM	`39.04% <ø> (?)`
rocRAND	`?`
rocSOLVER	`?`
rocSPARSE	`?`

Files with missing lines	Coverage Δ
...ts/rocprim/rocprim/include/rocprim/type_traits.hpp	`65.27% <ø> (ø)`

... and 1992 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-05-16T01:01:30Z

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

Add new commits
Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

Dismissing old review since the issues have been addressed.

Note: this is a rocm-libraries-based copy of #4079 in case we need to make immediate changes. Add CCCL 3.0.x support for hipCUB library. Additional updates: fix CUB backend JIRA ID : EXSWSTRHPC-300 --------- Co-authored-by: Mátyás Aradi <matyas@streamhpc.com> Co-authored-by: Nara Prasetya <nara@streamhpc.com> Co-authored-by: Cenxuan Tian <cenxuan@streamhpc.com> Co-authored-by: Nguyen <zenguyen@amd.com>

feat(hipcub): Add CCCL 3.0.x support (copy) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Note: this is a rocm-libraries-based copy of ROCm/rocm-libraries#4079 in case we need to make immediate changes. Add CCCL 3.0.x support for hipCUB library. Additional updates: fix CUB backend JIRA ID : EXSWSTRHPC-300

matyas-streamhpc · 2026-07-27T10:42:29Z

Copy of PR made and modifications merged in #9931

umfranzw · 2026-07-27T13:28:03Z

Closing this PR, since the modified copy (#9931) has been merged.

…RSION' (pytorch#188072) # Context Recreated pytorch#184552 from personal fork. hipCUB is targeting to be compatible with CCCL 3.0 (ROCm/rocm-libraries#4079). This requires updating some of the CUB and hipCUB compatibility glue. To help this transition hipCUB will be exposing `HIPCUB_CCCL_VERSION` in one of the following ROCm releases (>=7.14) (ROCm/rocm-libraries#7632), which will be bumped once hipCUB reaches parity with CCCL 3.0 and beyond. This PR is created in anticipation for this future changes. # Implementation - Introduce dependency on [`libhipcxx`](https://github.com/ROCm/libhipcxx). - Guard `FpLimits` for `c10::BFloat16` backport to pre CCCL 3.x. Numeric limits are handled by libhipcxx. - Extend `CUB_VERSION` derivation for hipCUB. Keep old fallback for backwards compatibility. Only enable CUB V3 API once hipCUB reaches parity with CCCL 3.x. Pull Request resolved: pytorch#188072 Approved by: https://github.com/jeffdaily

github-actions Bot added documentation project: hipcub project: rocprim labels Jan 26, 2026

assistant-librarian Bot added the external contribution Code contribution from users community.. label Jan 26, 2026

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from b533ef0 to f0e93d0 Compare January 27, 2026 17:34

RobsonRLemos added the organization: streamhpc contributors from streamhpc label Jan 28, 2026

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from f0e93d0 to 425029f Compare January 29, 2026 10:36

matyas-streamhpc marked this pull request as ready for review January 29, 2026 10:50

matyas-streamhpc requested review from a team as code owners January 29, 2026 10:50

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 425029f to 45bf6cd Compare January 29, 2026 14:21

umfranzw reviewed Jan 30, 2026

View reviewed changes

Comment thread projects/hipcub/hipcub/include/hipcub/backend/cub/device/device_reduce.hpp Outdated

umfranzw reviewed Jan 31, 2026

View reviewed changes

Comment thread projects/hipcub/hipcub/include/hipcub/backend/cub/device/device_select.hpp Outdated

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 64c2f95 to a6bd6e0 Compare February 9, 2026 10:58

umfranzw previously requested changes Feb 11, 2026

View reviewed changes

Comment thread projects/rocprim/CHANGELOG.md Outdated

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from a6bd6e0 to 01c6c4a Compare February 11, 2026 19:37

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 01c6c4a to 5129a04 Compare March 5, 2026 08:50

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch 3 times, most recently from e012a58 to c38a3c2 Compare March 16, 2026 13:04

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from b146369 to 89a22db Compare March 18, 2026 13:51

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 89a22db to 6019c3c Compare March 23, 2026 11:49

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 6019c3c to 555b351 Compare April 20, 2026 15:05

github-actions Bot added the Stale PR has no activity for 25+ days label May 16, 2026

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 555b351 to 1441fba Compare May 19, 2026 14:36

matyas-streamhpc and others added 14 commits July 23, 2026 16:41

Remove internal hipcub::Equality usage

89ea1bf

Remove internal hipcub::Max usage

4b0c52e

Remove internal usage of hipcub::Sum

7746398

Remove headers that include internally used thread operators

25a03d6

Deprecate thread operators

894b4a4

Remove tests of deprecated thread operators

96e8a7f

Deprecate and replace hipcub::BFE

6a4b0a3

Fix libhipcxx version check

879e2f1

Add sort_last for custom test type

cc526bb

Update device reduce test cases

eee9d79

Add numeric_limits support for custom test types

e65e9fe

Skip unsupported bfloat16/half histogram tests

f7dfaa2

feat(hipcub): add infrastructure to expose the compatible cccl version

5434625

fix(hipcub): Fix address sanitizer test header for CUDA

95883a9

matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 5f74f48 to 95883a9 Compare July 23, 2026 16:42

umfranzw approved these changes Jul 23, 2026

View reviewed changes

umfranzw mentioned this pull request Jul 24, 2026

feat(hipcub): Add CCCL 3.0.x support (copy) #9931

Merged

spolifroni-amd approved these changes Jul 24, 2026

View reviewed changes

umfranzw closed this Jul 27, 2026

Navigation Menu

Uh oh!

feat(hipcub): Add CCCL 3.0.x support - #4079

feat(hipcub): Add CCCL 3.0.x support#4079
matyas-streamhpc wants to merge 96 commits into
ROCm:developfrom
StreamHPC:users/matyas-streamhpc/hipcub-cccl-3-0

matyas-streamhpc commented Jan 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stanleytsang-amd commented Feb 27, 2026

Uh oh!

stanleytsang-amd commented Mar 2, 2026

Uh oh!

matyas-streamhpc commented Mar 9, 2026

Uh oh!

codecov-commenter commented Mar 19, 2026

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

matyas-streamhpc commented Jul 27, 2026

Uh oh!

umfranzw commented Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

matyas-streamhpc commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stanleytsang-amd commented Feb 27, 2026

Uh oh!

stanleytsang-amd commented Mar 2, 2026

Uh oh!

matyas-streamhpc commented Mar 9, 2026

Uh oh!

codecov-commenter commented Mar 19, 2026

Codecov Report

Uh oh!

github-actions Bot commented May 16, 2026

Uh oh!

matyas-streamhpc commented Jul 27, 2026

Uh oh!

umfranzw commented Jul 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

matyas-streamhpc commented Jan 26, 2026 •

edited

Loading