Skip to content

Revert "feat(hipcub): Add CCCL 3.0.x support (copy)" - #9992

Draft
amd-chiranjeevi wants to merge 1 commit into
developfrom
revert-9931-users/umfranzw/hipcub_cccl3.0_copy
Draft

Revert "feat(hipcub): Add CCCL 3.0.x support (copy)"#9992
amd-chiranjeevi wants to merge 1 commit into
developfrom
revert-9931-users/umfranzw/hipcub_cccl3.0_copy

Conversation

@amd-chiranjeevi

@amd-chiranjeevi amd-chiranjeevi commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Reverts PR: #9931
Fixes Issue: #9993

@therock-pr-bot

therock-pr-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ✅ Pass
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled
🤖 therock-pr-bot ✅ Pass

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.12329% with 48 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ipcub/include/hipcub/backend/rocprim/util_type.hpp 0.00% 28 Missing ⚠️
...ckend/rocprim/iterator/discard_output_iterator.hpp 18.18% 9 Missing ⚠️
...hipcub/backend/rocprim/thread/thread_operators.hpp 27.27% 8 Missing ⚠️
...backend/rocprim/device/device_segmented_reduce.hpp 95.00% 1 Missing ⚠️
...lude/hipcub/backend/rocprim/device/device_spmv.hpp 96.67% 0 Missing and 1 partial ⚠️
...pcub/include/hipcub/backend/rocprim/util_macro.hpp 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9992      +/-   ##
===========================================
- Coverage    69.55%   69.55%   -0.00%     
===========================================
  Files         2739     2740       +1     
  Lines       450640   450738      +98     
  Branches     66350    66349       -1     
===========================================
+ Hits        313431   313494      +63     
- Misses      117008   117043      +35     
  Partials     20201    20201              
Flag Coverage Δ *Carryforward flag
TensileLite 34.33% <ø> (ø) Carriedforward from 7707255
TensileLite-CPP 38.06% <ø> (ø) Carriedforward from 7707255
TensileLite-Unit 64.65% <ø> (ø) Carriedforward from 7707255
hipBLAS 90.62% <ø> (ø) Carriedforward from 7707255
hipBLASLt 34.63% <ø> (ø) Carriedforward from 7707255
hipCUB 82.68% <67.12%> (-0.79%) ⬇️
hipDNN 86.35% <ø> (ø) Carriedforward from 7707255
hipFFT 47.34% <ø> (ø) Carriedforward from 7707255
hipRAND 76.12% <ø> (ø) Carriedforward from 7707255
hipSOLVER 69.18% <ø> (ø) Carriedforward from 7707255
hipSPARSE 86.27% <ø> (ø) Carriedforward from 7707255
rocBLAS 47.95% <ø> (ø) Carriedforward from 7707255
rocFFT 47.61% <ø> (ø) Carriedforward from 7707255
rocRAND 57.01% <ø> (ø) Carriedforward from 7707255
rocSOLVER 76.92% <ø> (ø) Carriedforward from 7707255
rocSPARSE 72.59% <ø> (ø) Carriedforward from 7707255
rocThrust 91.60% <ø> (+0.01%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...ckend/rocprim/agent/single_pass_scan_operators.hpp 45.45% <ø> (ø)
.../hipcub/backend/rocprim/block/block_radix_sort.hpp 0.00% <ø> (ø)
...nclude/hipcub/backend/rocprim/block/block_scan.hpp 0.00% <ø> (ø)
...kend/rocprim/device/device_adjacent_difference.hpp 100.00% <ø> (ø)
...lude/hipcub/backend/rocprim/device/device_copy.hpp 100.00% <ø> (ø)
...clude/hipcub/backend/rocprim/device/device_for.hpp 82.68% <100.00%> (+1.32%) ⬆️
...hipcub/backend/rocprim/device/device_histogram.hpp 97.53% <100.00%> (+0.03%) ⬆️
...de/hipcub/backend/rocprim/device/device_memcpy.hpp 100.00% <ø> (ø)
...ude/hipcub/backend/rocprim/device/device_merge.hpp 100.00% <ø> (ø)
...ipcub/backend/rocprim/device/device_merge_sort.hpp 100.00% <ø> (ø)
... and 19 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@umfranzw

Copy link
Copy Markdown
Contributor

Note: ROCm/TheRock#6890 has been created to remove PyTorch 2.10 from TheRock build matrices. Once merged, that should eliminate the need to revert the CCCL 3.0 changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants