Skip to content

Enable ASLR#16878

Merged
Megamouse merged 8 commits intoRPCS3:masterfrom
Vestrel:aslr
Apr 30, 2025
Merged

Enable ASLR#16878
Megamouse merged 8 commits intoRPCS3:masterfrom
Vestrel:aslr

Conversation

@Vestrel
Copy link
Copy Markdown
Contributor

@Vestrel Vestrel commented Mar 17, 2025

Tested on x86 (without TSX) and linux arm (qemu). Had to compile discord-rpc from source since precompiled libs don't have pic flag enabled.

@Megamouse
Copy link
Copy Markdown
Contributor

Please move the discord stuff to a separate PR

@Vestrel Vestrel marked this pull request as draft March 18, 2025 11:13
@Megamouse Megamouse requested a review from kd-11 March 18, 2025 19:55
@Vestrel Vestrel force-pushed the aslr branch 2 times, most recently from 3acc568 to a218bce Compare March 21, 2025 00:49
@Vestrel Vestrel marked this pull request as ready for review March 21, 2025 00:50
@AniLeo AniLeo requested a review from elad335 March 22, 2025 20:48
@AniLeo AniLeo added Enhancement Refactoring Refactors or simplifies existing code labels Mar 22, 2025
@kd-11
Copy link
Copy Markdown
Contributor

kd-11 commented Mar 23, 2025

I tested windows x86 a bit since yesterday and that seems fine. I need to find some time to test arm64 linux and macos.

@kd-11
Copy link
Copy Markdown
Contributor

kd-11 commented Mar 23, 2025

Which reminds me - patches also needs to be tested, especially the more complicated ones that use falloc

@AniLeo
Copy link
Copy Markdown
Member

AniLeo commented Mar 25, 2025

Tested a few games on Linux x64, everything looks the same as master:

  • God of War Ascension: First battle with the spider
  • MotorStorm: First race
  • NieR Replicant: Load into Village, Lost Shrine: Roof
  • Sonic Unleashed: Windmill Isle
  • The Last of Us: Load into Prologue House, Wilderness areas
  • VSH: First setup and boot
  • Yakuza Dead Souls: Load into Kamurocho

Created LLVM firmware cache from scratch too

Comment thread rpcs3/util/shared_ptr.hpp
@Vestrel Vestrel marked this pull request as draft April 1, 2025 06:18
@Vestrel Vestrel force-pushed the aslr branch 3 times, most recently from 318cbd8 to 3e2ed9e Compare April 3, 2025 05:29
@elad335 elad335 changed the title [TEST] Enable ASLR [POSTPONED TO NEXT CACHE UPGRADE] Enable ASLR Apr 3, 2025
@elad335 elad335 added the LLVM Related to LLVM instruction decoders label Apr 3, 2025
@elad335 elad335 changed the title [POSTPONED TO NEXT CACHE UPGRADE] Enable ASLR Enable ASLR Apr 3, 2025
Copy link
Copy Markdown
Contributor

@elad335 elad335 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are approved, it will be merged in the next PPU cache update.

@Vestrel Vestrel marked this pull request as ready for review April 3, 2025 14:32
Copy link
Copy Markdown
Contributor

@kd-11 kd-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement LLVM Related to LLVM instruction decoders Refactoring Refactors or simplifies existing code To-Be-Merged In Cache Upgrade

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants