fix(build): improve Rust toolchain detection on Windows#105
fix(build): improve Rust toolchain detection on Windows#105TheVeryDarkness merged 19 commits intoRPL-Toolchain:masterfrom
Conversation
|
fix(build): improve Rust toolchain detection on Windows, add relevant rustfmt.exe path |
|
Could you update the CI workflow to include Windows in the matrix? Specifically, please modify the |
|
|
Sorry, I didn't notice this. Let me take a look at it tomorrow. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances Windows compatibility for the RPL toolchain by improving Rust toolchain detection on Windows systems. The changes ensure the build process correctly locates rustfmt.exe on Windows platforms and adds CI testing for Windows.
Key changes:
- Fixed rustfmt executable detection to use
.exeextension on Windows - Added Windows to the CI matrix for continuous testing
- Documented Windows-specific setup requirements
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| crates/rpl_parser/build.rs | Platform-specific rustfmt executable detection for Windows compatibility |
| README.md | Added Windows-specific installation instructions for RUSTUP_HOME setup |
| .github/workflows/main.yml | Extended CI to test on Windows and added cargo caching |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Set default shell to bash for job runs.
Removed environment variable CARGO_TERM_COLOR from workflow.
|
It's weird that ''s aren't normalized to '/' by ui-test, and maybe I can debug this on a PC tomorrow or this weekend. |
See config.rs in |
|
It seems that the bug has been fixed in |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This should hrlp with <RPL-Toolchain#105>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 22 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| //@ normalize-stderr-test: "\d+:\d+ ~ (\w+)\[[0-9a-f]{4}\]" -> "$1" | ||
| //@ normalize-stderr-test: "/.*/lib/rustlib/src/rust/library" -> "$$SRC_DIR" | ||
| //@ normalize-stderr-test: "span: (.*):(\d+):(\d+): (\d+):(\d+) \(#\d+\)" -> "span: $1:$2:$3: $4:$5 (#N)" | ||
| //@ normalize-stderr-test: "DefId\(\d+:\d+ ~ (\w+)\[[0-9a-f]{4}\]" -> "DefId($1" |
There was a problem hiding this comment.
The regex replacement target is missing a closing parenthesis. It should be "DefId($1)" instead of "DefId($1". This will result in malformed output in the stderr normalization.
| //@ normalize-stderr-test: "DefId\(\d+:\d+ ~ (\w+)\[[0-9a-f]{4}\]" -> "DefId($1" | |
| //@ normalize-stderr-test: "DefId\(\d+:\d+ ~ (\w+)\[[0-9a-f]{4}\]" -> "DefId($1)" |
…e CONTRIBUTING.md and README.md for clarity
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ter Windows compatibility
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 22 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Ah, finally |
3 participants
No description provided.