A new IntTy for integer literals without suffix#109
Merged
stuuupidcat merged 1 commit intoRPL-Toolchain:masterfrom Jan 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new IntTy::AnyInt variant to represent integer literals without a type suffix, enabling them to match MIR constants with any integer type that has the same mathematical value. Previously, unsuffixed integer literals defaulted to Usize, but with this change they can match both signed and unsigned integer types.
Changes:
- Added
IntTy::AnyIntenum variant for unsuffixed integer literals - Updated integer matching logic to accept
AnyIntwith any signed or unsigned integer type - Modified normalization and pretty-printing to handle
AnyIntappropriately
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/rpl_context/src/pat/ty.rs | Adds AnyInt variant to IntTy enum; updates from_integer to return AnyInt for unsuffixed literals; modifies normalize to handle AnyInt by returning value unchanged |
| crates/rpl_match/src/statement.rs | Updates constant matching logic to accept AnyInt patterns matching any Int or Uint MIR type |
| crates/rpl_context/src/pat/pretty.rs | Implements Debug formatting for AnyInt to display integer value without type suffix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An integer literal without suffix now can be matched with any constants with the same mathematical value.