Convert paths with cygpath if available in build-docker.sh #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The utility cygpath is available under Cygwin or MSYS2 which is used for "Git Bash". These are two of the most common ways to run a shell script on Windows.
This commit updates build-docker.sh to use cygpath to convert arguments to Docker into the correct native format when running on Windows.
NB 1: converting DIR is not necessary on MSYS2 because the conversion layer does it for you when it sees that docker isn't linked to msys. This doesn't work for CONFIG_FILE because the converter doesn't recognize the -v xx:yy:zz syntax for setting up a volume.
NB 2: I have used cygpath -d rather than cygpath -w because this gives a path without spaces or wide-characters.