-
Notifications
You must be signed in to change notification settings - Fork 1
Organisation member management #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@param organisation: The organisation to remove the user from | ||
@param removed_user: The user to revoke permissions from | ||
""" | ||
if not self.can_edit(user, organisation): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This permission check wasn't here before.
Can we add an "Invite pending" list on the page with the ability to cancel the invite? |
Yeah that's doable. Sub issue #256 |
Is it meant to be sending emails with the invitation? I've been testing locally with maildev, it doesn't seem to be catching any sent emails and no errors were raised either. Otherwise the rest of the functionalities seem to be working fine. |
Yes it sends emails - do you have the console email plugin enabled? # .env
DJANGO_EMAIL_BACKEND=django.core.mail.backends.console.EmailBackend I'm not sure how email stuff is configured in this branch |
Once you've been invited and accepted you can't be invited again (e.g. if the invitee deleted their user account but want to be invited again to the project). I'm guessing you'll need to run the command to clear the invitations list first? |
Ah right, yeah it makes an The records are tied to a user registration, rather than being added/removed to an org. Also, if someone was invited, joined, and then removed, you wouldn't be able to add them to the org again at all. |
We could make it so that someone can be added to an org straight away if that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work!
About not getting email in maildev I'm assuming it's configuration issue on my end so you can ignore that.
Other issues I've mentioned are lower priority and can be addressed in a separate PR.
Issue #21
Changes:
OrganisationService.remove_user_from_organisation
/myorganisation/members/invite
/signup/nmtgy0txpg02idzupxjwx9mw46iehmyycvvnbkfkt09fizfjg74mjwcggau0nf9k
Remove user