Skip to content

[CybernewsBridge] add LIBXML_NONET and fix lint #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
Merged

[CybernewsBridge] add LIBXML_NONET and fix lint #4727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions bridges/CybernewsBridge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,40 +13,39 @@ class CybernewsBridge extends BridgeAbstract

public function collectData()
{
$sitemapXml = getContents(self::URI . '/news-sitemap.xml');
$sitemapUrl = self::URI . '/news-sitemap.xml';

$sitemapXml = getContents($sitemapUrl);
if (!$sitemapXml) {
throwServerException('Unable to retrieve Cybernews sitemap');
}

$sitemap = simplexml_load_string($sitemapXml, null, LIBXML_NOCDATA);

$sitemap = simplexml_load_string($sitemapXml, null, LIBXML_NOCDATA | LIBXML_NONET);
if (!$sitemap) {
throwServerException('Unable to parse Cybernews sitemap');
}

foreach ($sitemap->url as $entry) {
$url = trim((string) $entry->loc);
$lastmod = trim((string) $entry->lastmod);
$url = trim((string) $entry->loc);
$lastmod = trim((string) $entry->lastmod);

if (!$url) {
continue;
}

$pathParts = explode('/', trim(parse_url($url, PHP_URL_PATH), '/'));
$category = isset($pathParts[0]) && $pathParts[0] !== '' ? $pathParts[0] : '';
$pathParts = explode('/', trim(parse_url($url, PHP_URL_PATH), '/'));
$category = isset($pathParts[0]) && $pathParts[0] !== '' ? $pathParts[0] : '';

// Skip non-English versions
if (in_array($category, ['nl', 'de'], true)) {
continue;
}
// if (in_array($category, ['nl', 'de', 'es', 'it'], true)) {
// continue;
// }

$namespaces = $entry->getNamespaces(true);
$title = '';

if (isset($namespaces['news'])) {
$news = $entry->children($namespaces['news'])->news;

if ($news) {
$title = trim((string) $news->title);
}
Expand Down Expand Up @@ -74,18 +73,15 @@ public function collectData()
private function fetchFullArticle(string $url): string
{
$html = getSimpleHTMLDOMCached($url);

if (!$html) {
return 'Unable to fetch article content';
}

$article = $html->find('article', 0);

if (!$article) {
return 'Unable to parse article content';
}

// Remove unnecessary elements
$removeSelectors = [
'script',
'style',
Expand Down