Skip to content

[MinecraftBridge] fix: encode image URLs + refactor #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MinecraftBridge] fix: encode image URLs + refactor #4750

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 27 additions & 12 deletions bridges/MinecraftBridge.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?php

declare(strict_types=1);

class MinecraftBridge extends BridgeAbstract
{
const NAME = 'Minecraft';
Expand Down Expand Up @@ -31,28 +33,41 @@ public function getIcon()

public function collectData()
{
$json = getContents(
'https://www.minecraft.net/content/minecraftnet/language-masters/en-us/_jcr_content.articles.page-1.json'
);

$articles = json_decode($json);
$json = getContents('https://www.minecraft.net/content/minecraftnet/language-masters/en-us/_jcr_content.articles.page-1.json');

if ($articles === null) {
throwServerException('Failed to decode JSON content.');
$data = json_decode($json);
if ($data === null || empty($data->article_grid)) {
throwServerException('Invalid or empty content');
}

foreach ($articles->article_grid as $article) {
if ($article->primary_category !== $this->getInput('category') && $this->getInput('category') !== 'all') {
$category = $this->getInput('category');

foreach ($data->article_grid as $article) {
if ($category !== 'all' && $category !== $article->primary_category) {
continue;
}

$imageUrl = $this->getEncodedImageUrl($article->default_tile->image->imageURL);

$this->items[] = [
'title' => $article->default_tile->title,
'title' => trim($article->default_tile->title),
'uid' => $article->article_url,
'uri' => self::URI . $article->article_url,
'uri' => urljoin(self::URI, $article->article_url),
'content' => $article->default_tile->sub_header,
'categories' => [$article->primary_category],
'enclosures' => [self::URI . $article->default_tile->image->imageURL],
'enclosures' => $imageUrl ? [$imageUrl] : [],
];
}
}

private function getEncodedImageUrl(string $path): ?string
{
$path = explode('/', ltrim($path, '/'));
$path = array_map('rawurlencode', $path);
$path = implode('/', $path);

$url = urljoin(self::URI, $path);

return filter_var($url, FILTER_VALIDATE_URL) ? $url : null;
}
}