Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): onViewableItemsChanged is not reactive #2911

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Conversation

hyoban
Copy link
Member

@hyoban hyoban commented Feb 28, 2025

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Demo Video (if new feature)

Linked Issues

facebook/react-native#30171

Additional context

Changelog

  • I have updated the changelog/next.md with my changes.

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
follow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 8:41am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
follow-external-ssr ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 8:41am

@follow-reviewer-bot
Copy link

Suggested PR Title:

refactor(entry-list): simplify viewability handling in components

Change Summary:
Refactored entry list components to simplify viewability hooks. Removed unnecessary 'disabled' prop usage in viewable items hooks, enhancing readability and maintainability. Introduced a custom hook, 'useNonReactiveCallback', to prevent stale closures, ensuring the 'onViewableItemsChanged' handler operates with the latest function context.

Code Review:
No change requests necessary.

@hyoban hyoban marked this pull request as ready for review February 28, 2025 08:44
@hyoban hyoban merged commit 30aef70 into dev Feb 28, 2025
11 checks passed
@hyoban hyoban deleted the fix/mark-as-read branch February 28, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant