feat: Compatibility with new hp/toolbar buttons only #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mateusfreira - could you review this? I need this change for the beta branch of flexview. |
wayfarer3130
commented
May 26, 2023
| @@ -33,7 +33,7 @@ | |||
| "test:unit:ci": "jest --ci --runInBand --collectCoverage --passWithNoTests" | |||
| }, | |||
| "peerDependencies": { | |||
| "@cornerstonejs/tools": "^0.63.3", | |||
| "@cornerstonejs/tools": "^1.1.0", | |||
There was a problem hiding this comment.
This is the release cornerstonejs version series.
wayfarer3130
commented
May 26, 2023
| @@ -384,7 +372,6 @@ const toolbarButtons = [ | |||
| // ************ New Layout Section | |||
|
|
|||
| // Measurement | |||
| isNewHP ? | |||
There was a problem hiding this comment.
Just get rid of the old menu as the new one has been around for a while - uses the new hanging protocol service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the check of isNewHP, as that is now fairly old, and we can just default to being compatible