Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than 2 RPC buttons in the config file #105

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

JustTemmie
Copy link
Contributor

The title is pretty self explanatory, the loop that parses the buttons will break early whenever it reaches 2 entries.

This allows for stuff like this:

        "buttons": [
            {
                "name": "dynamic",
                "url": "dynamic"
            },
            {
                "name": "dynamic",
                "url": "dynamic"
            },
            {
                "name": "Cool Game :3",
                "url": "https://store.steampowered.com/app/1718240"
            }
        ]

Where the 3rd button is only shown if any of the dynamic buttons failed to be created for whatever reason

unsure if this actually needs to be documented anywhere, might be up for discussion

@Radiicall Radiicall self-assigned this Mar 15, 2024
Copy link
Owner

@Radiicall Radiicall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insane change

@JustTemmie
Copy link
Contributor Author

hey, you said it was probably an easy change

@Radiicall Radiicall merged commit 87efc0e into Radiicall:main Mar 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants