fix: domain like https://domain not allow#388
Merged
StephenHodgson merged 1 commit intoRageAgainstThePixel:developmentfrom Jan 11, 2025
Merged
fix: domain like https://domain not allow#388StephenHodgson merged 1 commit intoRageAgainstThePixel:developmentfrom
StephenHodgson merged 1 commit intoRageAgainstThePixel:developmentfrom
Conversation
the following use case where
```
var client = new OpenAIClient(new OpenAIAuthentication(key), new OpenAIClientSettings("https://domain"));
```
does not work, while both 'domain' and 'http://domain' work fine. This does not reflect the consistency of the API.
Member
|
@chsword Thanks for this, I'll try to get it in my next release |
StephenHodgson
approved these changes
Jan 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the following use case where
does not work, while both
domainandhttp://domainwork fine. This does not reflect the consistency of the API.After modification, parameters like
http://domain.xxxdomain.xxxhttps://domain.xxxare both allowed.