-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some 404s in META.list #567
Conversation
Looks like Travis fails because some of the META files have invalid versions, but invalid META files are infinitely better than unresolvable META files IMHO. |
It's even better with no errors... Most of them are easily solvable via a PR. I would really appreciate if you (or someone) did that... In some cases, #324 might also need to be addressed. |
It looks like one of these (https://github.com/supernovus/PSpec) is now archived and read-only (which means it won't get fixed). I'd suggest we remove it from the list (since it currently 404s, and making it not throw that error breaks tests). |
META.list
Outdated
https://raw.githubusercontent.com/raku-community-modules/raku-mime-types/master/META6.json | ||
https://raw.githubusercontent.com/supernovus/perl6-text-table-list/master/META6.json | ||
https://raw.githubusercontent.com/supernovus/perl6-timezone/master/META6.json | ||
https://raw.githubusercontent.com/supernovus/perl6-web-app-ballet/master/META.info | ||
https://raw.githubusercontent.com/supernovus/perl6-web-app-ballet/master/META6.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be at https://github.com/raku-community-modules/Web-App-Ballet/blob/master/META6.json now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, all supernovus modules were moved to the community. As long as you're changing it, use the new URL. If there's some error even then, we can accept the PR (or do the change ourselves) quickly.
META.list
Outdated
https://raw.githubusercontent.com/supernovus/perl6-web-app-mvc/master/META6.json | ||
https://raw.githubusercontent.com/supernovus/perl6-web-template/master/META6.json | ||
https://raw.githubusercontent.com/supernovus/perl6-web/master/META6.json | ||
https://raw.githubusercontent.com/supernovus/perl6-xml-query/master/META6.json | ||
https://raw.githubusercontent.com/supernovus/template6/master/META6.json | ||
https://raw.githubusercontent.com/supernovus/temporal-utils/master/META.info | ||
https://raw.githubusercontent.com/supernovus/temporal-utils/master/META6.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be now at https://github.com/raku-community-modules/DateTime-Utils/blob/master/META6.json
Removing something from the ecosystem is an extreme decision, and should be not taken lightly. For starters, it's much better if it's done in a separate statement. Then we'll have to check if there's any downstream dependency. It's probably not the case, but we need to check anyway. And then, of course, we'll have to notify the author just in case. |
I've forked PSpec into raku-community-modules |
I tried searching for it, but couldn't find it. Could it be hidden for some reason? I expected to find it here: https://github.com/raku-community-modules/PSpec but that gives me a 404 |
I've updated this PR to reflect some of the issues that were brought up. There are still some dists that are failing, but I think all of them have PRs now. |
Oops, I forked PSpec to perl6-community-modules by accident. It should be in raku-community-modules now. |
@jjatria but now there seem to be some conflicts, and I can't quite figure out some of them. Can you please check? |
@JJ Sure, I'll take a look. It's probably because I'm inserting the names where they ought to be if the list were sorted, but it's not. Maybe the test can enforce it being kept sorted? Or is sorting not something we care about at all? |
It might, but the problem here is that there seems to be a conflict, maybe because I've merged another PR in the meantime... |
@JJ I've resolved the merge conflicts with this commit |
And now there's a brand new conflict... |
@JJ Fixing the conflicts in this PR (again) will be of no use until the PRs that are blocking this one are merged. As far as I'm aware, they are:
Once those (or equivalent) PRs are merged, and this one is unblocked, I will happily deal with any new conflicts like I did in the past. |
Trying to fix the first now, but it's got errors in some upstream modules
too...
Thanks anyway.
|
@JJ Incidentally, in one of your previous comments you wrote
But I cannot find an equivalent for https://github.com/supernovus/perl6-method-modifiers. Does that one also need to be moved? If so, I can make the PR there instead, and update the META reference on this one. |
I really have no idea. It might have been overlooked, or who knows. Please
ping them, and if they don't answer, you can always adopt it.
|
As far as I know, supernovus sorted through his modules and only transferred those that had some value. Things that had been superseded or broken beyond repair he left out. |
We should probably then just eliminate that one. |
@JJ I'll go ahead and remove the change for that dist, then, and we can remove it in a separate PR |
A few dists have switched from META.info to the modern META6.json but not been updated here, until now. Changes in dist ownership are also reflected.
Inline::Scheme::Gambit is looking for Panda... Let's see what we can do there. |
I've opened a PR in p6-c-parser as well, that seems to use a no-longer-allowed (?) |
Still a couple of modules to go:
|
Is this PR still relevant? If so, what should be done about it? |
Well, it's conflicting, so it would really need work if we want to go ahead with it. We will probably need to open it anew, because there might be many more places that 404 |
I'm happy to resolve any conflicts on it, but it might be simpler to merge if we fix the 404s one by one rather than many in one go. FWIW: Inline::Scheme::Gambit has merged the fix for that failing test |
Please go ahead with whatever you think is best. |
Thanks for looking into it |
A few dists have switched from META.info to the modern META6.json but not been updated here, until now.
Obviously I don't own these modules but it's clear that at least some point the original authors wanted them to be here so we may as well make them work again :-)
I agree to the usage of the META file as listed here.
I have a license field listed in my META file that is one of https://spdx.org/licenses
In this case make sure you have a license URL listed under support. See this example.