Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding check for empty string as well as null #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reubenmiller
Copy link

When using the -Credentials parameter when calling Invoke-PSDepend for dependencies that don't require credentials, would result in the erroneous warning WARNING: No credential found for the specified name . Was the dependency misconfigured?

Example

Invoke-PSDepend -Path "./depends.psd1" -Install -Import -Credentials @{
  "repo1WithCredential" = (Get-Credential)
}

File depends.psd1

@{
    "PSModule1" = @{
        
        "Name"           = "PSModule1"
        "Version"        = "1.0.0"
        "DependencyType" = "PSGalleryModule"
        "Credential"     = "repo1WithCredential"
        "Parameters"     = @{
            "Repository" = "repo1WithCredential"
        }
    }
    "PSModule2" = @{
        "Name"           = "PSModule2"
        "Version"        = "2.1.0"
        "DependencyType" = "PSGalleryModule"
        "Parameters"     = @{
            "Repository" = "repo2WithoutCredential"
        }

Would generate the warning when processing the PSModule2 dependency.

WARNING: No credential found for the specified name . Was the dependency misconfigured?

Fix

The -Name parameter in Resolve-Credential is cast from $null to an empty string "". So now both null and an empty string are checked.

@reubenmiller
Copy link
Author

Resolves $null credential issue referenced at the end of #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant