Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #121 #122

Closed
wants to merge 4 commits into from
Closed

Closes #121 #122

wants to merge 4 commits into from

Conversation

fireflycons
Copy link

What I've done here is to borrow from powershell-yaml.
Differing versions of YamDotNet between this module and powershell-yaml gave me a right headache last month :-)
Now we have all 3 versions (.NET 3.5, .NET 4.5 and .NET Standard 1.3) and the appropriate one for the framework on which the powershell session is running will be loaded.

I also found a couple of test issues which I resolved.
In CopyVMFile.tests and PlatyPS.tests, the Invoke-PSDeploy call was returning multiple $true values in the pipeline - one for each result so Should Return Mocked output was failing

fireflycons added 4 commits May 5, 2019 10:57
@fireflycons
Add gitignore
e53fc2e
@fireflycons
Remove trailing whitespace
2102428
@fireflycons
Fix failing tests
3d77689 
- Should Return Mocked output: Multiple results returned in pipeline.
- Aggregate results before asserting overall result is true
@fireflycons
Closes #121
88b69ae 
- Upgrade YamlDotNet libs.
- Choose correct DLL for the PowerShell edition.
- Check that any pre-loaded DLL has what we need.
@fireflycons
Copy link
Author

Closing this as it is superseded by PR #130

@fireflycons fireflycons closed this Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fireflycons