Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add design proposal for common CG constraints #1483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShyamsundarR
Copy link
Member

No description provided.

Signed-off-by: Shyamsundar Ranganathan <[email protected]>

## Grouping decision

DRPC will carry an additional `spec.group` (or, `spec.async.group`) boolean,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aimed for an annotation in this PR: #1488

would be used to label the PVCs. (see storageID related design for properties of
this label).

The proposed label name is `ramendr.openshift.io/consistency-group`, with the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ELENAGER, your PR uses a different label name than the one proposed in this PR.

Either way is fine with me; I am just ensuring that this PR or yours is updated to reflect the agreed naming.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenamarMk I updated my PR to use the proposed label name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants