-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cg controllers for cephfs #1484
Conversation
bc4fa41
to
7b2dced
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The initial review looks good. There are still many placeholders, which is acceptable for now. A detailed review will follow next.
@youhangwang I completed the review of the source part. Overall, looks good to me. I didn't want to overwhelm the PR with |
74fd25f
to
c5880c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ReplicationDestination code looks good to me. The next step is to run it, validate its functionality, and observe its behavior.
Signed-off-by: youhangwang <[email protected]>
Signed-off-by: youhangwang <[email protected]>
Signed-off-by: youhangwang <[email protected]>
Signed-off-by: youhangwang <[email protected]>
Signed-off-by: youhangwang <[email protected]>
Signed-off-by: youhangwang <[email protected]>
Signed-off-by: youhangwang <[email protected]>
bd2a081
to
3e82303
Compare
jFYI added a tracker issue for any pending items that would not be addressed in this PR w.r.t CG support in Ramen, #1501 |
Signed-off-by: youhangwang <[email protected]>
Signed-off-by: youhangwang <[email protected]>
Manual tested the following use cases:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The CG-related code has been tested, and the happy path works in |
|
||
var err error | ||
|
||
cg, ok := rdSpec.ProtectedPVC.Labels[ConsistencyGroupLabel] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) This line can be moved inside the if
block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will change it in another pr once #1472 merged.
@@ -146,6 +167,33 @@ func (v *VRGInstance) reconcilePVCAsVolSyncPrimary(pvc corev1.PersistentVolumeCl | |||
return true | |||
} | |||
|
|||
cg, ok := pvc.Labels[ConsistencyGroupLabel] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) Same here. This line can be moved inside the if block
rdinCGs := []ramendrv1alpha1.VolSyncReplicationDestinationSpec{} | ||
|
||
for _, rdSpec := range v.instance.Spec.VolSync.RDSpec { | ||
cg, ok := rdSpec.ProtectedPVC.Labels[ConsistencyGroupLabel] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this
Add Consistency Group (CG) support for cephfs-related workload. The implementation follows the design in this document RamenDR#1356. Signed-off-by: youhangwang <[email protected]> (cherry picked from commit aefe73f)
Backport of upstream PR RamenDR#1484
move pr #1401 to this one as the main branch have changed a lot due to upgrade kubebuilder