Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drpc: set ProgressionWaitOnUserToCleanUp for both volsync and volrep #1520

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raghavendra-talur
Copy link
Member

Signed-off-by: Raghavendra Talur [email protected]

@raghavendra-talur
Copy link
Member Author

Need to add tests and check for regressions in volrep.

@raghavendra-talur raghavendra-talur changed the title tests: keep all suite cleanup functions in suite_test.go drpc: set ProgressionWaitOnUserToCleanUp for both volsync and volrep Sep 6, 2024
@raghavendra-talur raghavendra-talur marked this pull request as ready for review September 6, 2024 06:11
@raghavendra-talur raghavendra-talur force-pushed the rtalur-progression branch 2 times, most recently from 7202a24 to 632d221 Compare September 6, 2024 06:14
@BenamarMk
Copy link
Member

@raghavendra-talur, this approach won't work. It will result in deleting the (future) application PVC on the secondary. When you recreate the VRG, a new PVC will be created, requiring the entire volume to be transferred from the primary to the secondary. Even worse, if a failover occurs before a new backup is made, you'll be stuck without any available VolumeSnapshots to restore the PVCs.

@BenamarMk
Copy link
Member

Additionally, with CephFS volumes, we always retain the last snapshot, allowing the user to revert to the last known good snapshot to restore from if needed (for every action change). Deleting the VRG would remove all of that, including the ability to access this snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants