drpc: set ProgressionWaitOnUserToCleanUp for both volsync and volrep #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavendra-talur
force-pushed
the
rtalur-progression
branch
from
c3e00ac
to
5a6920a
Compare
|
Need to add tests and check for regressions in volrep. |
raghavendra-talur
changed the title
raghavendra-talur
force-pushed
the
rtalur-progression
branch
2 times, most recently
from
7202a24
to
632d221
Compare
Signed-off-by: Raghavendra Talur <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur
force-pushed
the
rtalur-progression
branch
from
632d221
to
68b54be
Compare
|
@raghavendra-talur, this approach won't work. It will result in deleting the (future) application PVC on the secondary. When you recreate the VRG, a new PVC will be created, requiring the entire volume to be transferred from the primary to the secondary. Even worse, if a failover occurs before a new backup is made, you'll be stuck without any available VolumeSnapshots to restore the PVCs. |
|
Additionally, with CephFS volumes, we always retain the last snapshot, allowing the user to revert to the last known good snapshot to restore from if needed (for every action change). Deleting the VRG would remove all of that, including the ability to access this snapshot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raghavendra Talur [email protected]