Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Sphinx to 5.3.0 #10018

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Bump Sphinx to 5.3.0 #10018

merged 1 commit into from
Jan 15, 2025

Conversation

LevBernstein
Copy link
Contributor

@LevBernstein LevBernstein commented Nov 19, 2024

Summary

Upgrade Sphinx to 5.3.0. This version is available in the Debian archive, but, unlike later versions, upgrading to it would not introduce significant breaking changes. This avoids the pitfalls of #9556. The only change I had to make was disabling table of contents entries for domain objects.

Sphinx 5.3.0 lacks the breaking changes to the gettext builder of the later versions, meaning builder.py doesn't need to be changed at all; it is still compatible with Python 3.8; it doesn't break the favicon; and it doesn't require bumping any of the other dependencies (sphinxcontrib-serializinghtml, etc.).

While #9938 mentions Sphinx 7.4.7 specifically, the issue at hand was that the version of Sphinx used here (4.4.0) was not available on the Debian archive; by switching to one that is, I think we can mark that issue as closed.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@benthetechguy
Copy link

Upgrade Sphinx to 5.3.0. This version is available in the Debian archive

This isn't very useful, because even if Debian stable has version 5.3.0, builds on Debian sid (the builds that propagate to Ubuntu) would be using the version in Debian sid, currently 8.1.3.

Bumping to 5.3.0 only helps builds on Debian stable, even though there's already a perfectly working build there, and builds on Debian stable don't affect Ubuntu, which is the platform of the issue you opened this PR for.

@Rapptz Rapptz merged commit bb5a470 into Rapptz:master Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants