Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multisubscriptions #10042

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Conversation

DA-344
Copy link
Contributor

@DA-344 DA-344 commented Dec 12, 2024

Summary

Adds support for multi-subscriptions.

DDevs PR: discord/discord-api-docs#7304

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

discord/subscription.py Show resolved Hide resolved
discord/types/subscription.py Outdated Show resolved Hide resolved
@Rapptz Rapptz added the needs review This PR will be reviewed in the future label Jan 15, 2025
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay, it's a bit low level though so it doesn't feel particularly useful though the state of the library at this point when it comes to this is something I'm still fighting in my head. Anyway, doesn't impact this PR so it's good to go.

@Rapptz Rapptz merged commit ff2ad34 into Rapptz:master Jan 19, 2025
8 checks passed
@Rapptz Rapptz removed the needs review This PR will be reviewed in the future label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants