-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Raw Presence Updates #10048
Open
EvieePy
wants to merge
39
commits into
Rapptz:master
Choose a base branch
from
EvieePy:feature/raw-presence
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+262
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCausc78
reviewed
Dec 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually needed this feature. Thanks.
LostLuma
reviewed
Dec 21, 2024
LostLuma
reviewed
Dec 22, 2024
Rapptz
requested changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks mostly okay, just a bit confusing at places.
Co-authored-by: MCausc78 <[email protected]>
Co-authored-by: Danny <[email protected]>
Co-authored-by: Danny <[email protected]>
…cord.py into feature/raw-presence
LostLuma
reviewed
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A current limitation of the library is not being able to listen to presence updates without meeting certain requirements, namely needing both member intents and a member and guild cache. In cases where these requirements are not available or desired, presence updates are still received and discarded. This PR adds functionality for the
on_raw_presence_update
event, which allows anyone not subscribed to member intents or not using a member or guild cache to receive presence update events.Currently the implementation is semi opt-in, allowing anyone to manually enable or disable raw presences via the new
Client
keyword parameter. By default this event is only enabled automatically when a user haspresences
intents enabled andmembers
intents disabled, as this would mean they could not receive the currently availableon_presence_update
event.Added
on_raw_presence_update
RawPresenceUpdateEvent
model received in the event and used inMember
to update presence data.Client(enable_raw_presences=...)
keyword argument.ClientStatus
- Previously a private internal. The model representing Client Status data from discord.Member.client_status
- Previously a private internal.Checklist