Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cicd #1

Merged
merged 19 commits into from
Oct 27, 2023
Merged

Cicd #1

merged 19 commits into from
Oct 27, 2023

Conversation

enryH
Copy link
Member

@enryH enryH commented Oct 16, 2023 •
edited
Loading

  • add docs with Sphinx (and publish these in using ReadTheDocs CI)
  • add docstrings to modules, functions and classes
  • format code
  • update python package information
  • add some testing and consistency checks in GitHub Actions

Henry added 19 commits March 15, 2023 13:17
🚧 setup base package
6f2243b 
- reference version from setup.cfg in njab package
- define build tools
- add pkg metadata in setup.cfg
✨ get tox to run
003b2e2
🎨 format using yapf with pep8
1fd1200
🚨 flake8 and flake8-bugbear compatibiliy
96afa1e 
- F401 error : include __all__, and remove some unnecessary import
- B006: no mutable default arguments
- B008: no function or instance contruction in function parameters
- B020: rename assigned in for loop (text used twice)

next: need to add a few integration tests
🎨 yapf 0.31.0 -> 0.32.0 , update tox configs
0cc5212 
- artefact of formatting?
- update tox configurations
✨ setup basic documentation
d7c3562 
- tox environments don't manage to build references
  -> future annotations for python 3.8 don't work...
  -> find out why
🐛 compability with python 3.8 for type annotations
b84ece1
🎨 visualizations and display fixes
4b73dc5
👷 check formatting and linting
204b17e
✨ setup testing directory
d455956
📝 build documentation locally
35f955e 
will be done in readthedocs once published
📝 docstrings for submodules and functions
a5833bf
✅ add test from comments, test import
b663f1e 
on scoring
🎨 format with yapf
f9cce9b
🐛 yapf 40.2 formatting
6e62b95
:sparkes: readthedocs dependencies
e72e742
📝 add README of repo as landing page
422a285
🐛 comment and empty line error, adapt title
e959786
✨ Add source code view
455c385
@enryH enryH marked this pull request as ready for review October 27, 2023 14:45
@enryH enryH merged commit ffddd4a into main Oct 27, 2023
5 checks passed
@enryH enryH deleted the cicd branch October 27, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@enryH