🐛👷 add pytest-cov, try deactivating MPS

RasmussenLab · Aug 16, 2023 · 650b37c · 650b37c
1 parent 5ab9f2b
commit 650b37c
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -81,7 +81,7 @@ jobs:
           python-version: ${{ matrix.python-version }}
 
       - name: Install pytest
-        run: python -m pip install pytest
+        run: python -m pip install pytest pytest-cov
 
       - name: Run pytest
         run: pytest .
diff --git a/project/01_1_train_CF.ipynb b/project/01_1_train_CF.ipynb
@@ -375,6 +375,11 @@
     "                           model_dir=args.out_models)\n",
     "if args.cuda:\n",
     "    ana_collab.learn.model = ana_collab.learn.model.cuda()\n",
+    "else:\n",
+    "    # try to set explicitly cpu in case not cuda\n",
+    "    # MPS logic might not work properly in fastai yet https://github.com/fastai/fastai/pull/3858\n",
+    "    ana_collab.learn.model = ana_collab.learn.model.cpu()\n",
+    "\n",
     "# learn.summary() # see comment at DAE"
    ]
   },

diff --git a/project/01_1_train_CF.py b/project/01_1_train_CF.py
@@ -6,7 +6,7 @@
 #       extension: .py
 #       format_name: percent
 #       format_version: '1.3'
-#       jupytext_version: 1.14.5
+#       jupytext_version: 1.15.0
 #   kernelspec:
 #     display_name: Python 3
 #     language: python
@@ -209,6 +209,11 @@
                            model_dir=args.out_models)
 if args.cuda:
     ana_collab.learn.model = ana_collab.learn.model.cuda()
+else:
+    # try to set explicitly cpu in case not cuda
+    # MPS logic might not work properly in fastai yet https://github.com/fastai/fastai/pull/3858
+    ana_collab.learn.model = ana_collab.learn.model.cpu()
+
 # learn.summary() # see comment at DAE
 
 # %% [markdown]