-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #52
Commits on Sep 13, 2023
-
✨ dump and rename peptide files with PEP score
create a new intermediate dump of 7,444 HeLa runs
Henry Webel committedSep 13, 2023 Configuration menu - View commit details
-
Copy full SHA for e2e7521 - Browse repository at this point
Copy the full SHA e2e7521View commit details
Commits on Sep 14, 2023
-
✨ KNN comp. in updated workflow (v2)
- KNN dumps val and test data with specified "args.model_key" in "config.yaml" - update color palette for "unknown" models - make performance_plots.py more robust - training configs are created and saved on the fly (-> avoid separate model configs, collect all in one) R methods are fixed, no customization so far. To do this one would probably need to generate separte NBs for each method.
Henry committedSep 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 771178f - Browse repository at this point
Copy the full SHA 771178fView commit details
Commits on Sep 15, 2023
-
based on Lazar et. al. (2016) - below a quantile -> MNAR, select from there - quantile is defined based on overall frac of missing values - mix MCAR and MNAR - format and clean-up code in script
Henry committedSep 15, 2023 Configuration menu - View commit details
-
Copy full SHA for afc4f02 - Browse repository at this point
Copy the full SHA afc4f02View commit details
Commits on Sep 18, 2023
-
🐛 regression: use filtered dataset
- refactoring error -> select correct data
Henry committedSep 18, 2023 Configuration menu - View commit details
-
Copy full SHA for ac66abc - Browse repository at this point
Copy the full SHA ac66abcView commit details -
⚡ CICD pipeline: some R methods are slow
- only test CF, DAE and VAE functionally - select configs in example folder...
Henry committedSep 18, 2023 Configuration menu - View commit details
-
Copy full SHA for a2b97b8 - Browse repository at this point
Copy the full SHA a2b97b8View commit details -
🎨 format all code using autopep8
- both scripts (notebooks) - and library code
Henry committedSep 18, 2023 Configuration menu - View commit details
-
Copy full SHA for 13dba85 - Browse repository at this point
Copy the full SHA 13dba85View commit details
Commits on Sep 19, 2023
-
- msImpute - trKNN (from source) Add to workflow check.
Henry committedSep 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 0517113 - Browse repository at this point
Copy the full SHA 0517113View commit details
Commits on Sep 20, 2023
-
✨ group plots by seocndary nb number
- start grouping output for an easier overview (than only alphabetical)
Henry committedSep 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 25468d2 - Browse repository at this point
Copy the full SHA 25468d2View commit details
Commits on Sep 27, 2023
-
- update depreciated functionality in pandas -> some scripts might have further depreciation warnings
Henry committedSep 27, 2023 Configuration menu - View commit details
-
Copy full SHA for a1dfa2b - Browse repository at this point
Copy the full SHA a1dfa2bView commit details -
- igraph installation in conda on the fly fails for windows otherwise: https://stackoverflow.com/a/71711600/9684872
Henry committedSep 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 7118bec - Browse repository at this point
Copy the full SHA 7118becView commit details -
🐛 remove peptides from reversed protein groups
- reversed decoy sequence matches should be removed (it's only a few)
Henry committedSep 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 1da36a6 - Browse repository at this point
Copy the full SHA 1da36a6View commit details -
Henry Webel committed
Sep 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 9725406 - Browse repository at this point
Copy the full SHA 9725406View commit details -
- grouping of plots was not reflected in Snakemake workflow
Henry committedSep 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 4085578 - Browse repository at this point
Copy the full SHA 4085578View commit details -
- aim: specify long run time for R jobs with a high max - run long running job in parallel on one big node
Henry committedSep 27, 2023 Configuration menu - View commit details
-
Copy full SHA for 2dbd185 - Browse repository at this point
Copy the full SHA 2dbd185View commit details -
✨ enable torque cluster execution
- log file paths for submitted jobs added (should be unique) - -V: forward set environment for submitted job
Henry Webel committedSep 27, 2023 Configuration menu - View commit details
-
Copy full SHA for c5236f7 - Browse repository at this point
Copy the full SHA c5236f7View commit details
Commits on Sep 29, 2023
-
🐛 remove reversed sequences from evidence
- precursors from reversed protein sequences are removed from the evidence table - adapt code to use local information (yaml files)
Henry committedSep 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 6d8ecbf - Browse repository at this point
Copy the full SHA 6d8ecbfView commit details -
⬆️ remove constraints on pandas and pytorch
- colab uses pandas and pytorch two - datetime_is_numeric parameter removed from describe, see https://pandas.pydata.org/docs/whatsnew/v2.0.0.html
Henry committedSep 29, 2023 Configuration menu - View commit details
-
Copy full SHA for 8a4ab8b - Browse repository at this point
Copy the full SHA 8a4ab8bView commit details
Commits on Oct 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 12218c5 - Browse repository at this point
Copy the full SHA 12218c5View commit details -
✨📝 specify task specific log files
in case a tool, e.g. the torque scheduler, creates log files, these can be requested per task (job): in the run_snakememake_cluster bash script, this is done using -e and -o options.
Henry Webel committedOct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for 26dc891 - Browse repository at this point
Copy the full SHA 26dc891View commit details -
🔧 set default to cpu (no accelerator, e.g. gpu)
Henry Webel committedOct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for c7503e1 - Browse repository at this point
Copy the full SHA c7503e1View commit details -
✨ torque (qsub) script with parameters using -v
- submit required parameters using the -v option, e.g. qsub run_snakemake_cluster.sh \ -N snakemake_exp0 \ -v configfile=path_to/config.yaml,prefix=exp0
Henry Webel committedOct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for 6e780a2 - Browse repository at this point
Copy the full SHA 6e780a2View commit details -
🎨🐛 reverse column for evidence, rename all dumps
- rename also protein groups and precursors (evidence) dumps - drop entries from reversed sequences in evidence files
Henry Webel committedOct 9, 2023 Configuration menu - View commit details
-
Copy full SHA for 0fcc086 - Browse repository at this point
Copy the full SHA 0fcc086View commit details
Commits on Oct 10, 2023
-
🐛 methods that give all NA are not filtered
- increase robustness of notebook, ignoring all NA methods (here: IMPSEQ) - To consider: should 01_1_train_NAGuideR.ipynb throw an error if all pred are NAs?
Henry Webel committedOct 10, 2023 Configuration menu - View commit details
-
Copy full SHA for 2c78071 - Browse repository at this point
Copy the full SHA 2c78071View commit details
Commits on Oct 11, 2023
-
🎨✨ unify and showcase internals, add IDs
- function loading and filtering data - add IDs making it possible to make precursors (Evidence IDs), Peptide ID and Protein Groups IDs to each other. in a file the id column is always "id" (e.g. proteinGroups.txt id column = Protein Groups IDs in the other two)
Henry Webel committedOct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for 8b3ffc8 - Browse repository at this point
Copy the full SHA 8b3ffc8View commit details -
🎨📝 order by R methods by alphabet, start documenting
- tbc: see what works Next: merge with version where parameters for python based models can be set in config.yaml
Henry Webel committedOct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for f53aa96 - Browse repository at this point
Copy the full SHA f53aa96View commit details -
Merge pull request #49 from RasmussenLab/filter_reversed
Filter reversed -> parts for collecting data will be factored out
Henry Webel authoredOct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for cfc5fe5 - Browse repository at this point
Copy the full SHA cfc5fe5View commit details -
Merge pull request #50 from RasmussenLab/pbs_cluster_exec
🚧 prepare cluster execution - default: CPU execution, not accelerated (e.g. GPU) - job script for torque cluster - logs with notebook outputs
Henry Webel authoredOct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for c00f600 - Browse repository at this point
Copy the full SHA c00f600View commit details -
Merge pull request #51 from RasmussenLab/pip_dependencies
⬆️ remove constraints on pandas and pytorch -> faster setup on google collab - less constraints on version
Henry Webel authoredOct 11, 2023 Configuration menu - View commit details
-
Copy full SHA for 41ace60 - Browse repository at this point
Copy the full SHA 41ace60View commit details
Commits on Oct 12, 2023
-
🔥 move hela data collection code to new repo
-> https://github.com/RasmussenLab/hela_qc_mnt_data commit link: RasmussenLab/hela_qc_mnt_data@f88586b - make minor adaption needed due to deletions
Henry committedOct 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 5b3c0b0 - Browse repository at this point
Copy the full SHA 5b3c0b0View commit details
Commits on Oct 16, 2023
-
Merge pull request #53 from RasmussenLab/move_hela_data_code
🔥 move hela data collection code to new repo: https://github.com/RasmussenLab/hela_qc_mnt_data
Henry Webel authoredOct 16, 2023 Configuration menu - View commit details
-
Copy full SHA for fd1d07d - Browse repository at this point
Copy the full SHA fd1d07dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02b2d9f - Browse repository at this point
Copy the full SHA 02b2d9fView commit details -
✨ Integrate data splitting config into main config
- allow to set frac_mnar from commandline using: --config frac_mnar=.5 - dump created data config using separate rule (into experiment folder)
Henry committedOct 16, 2023 Configuration menu - View commit details
-
Copy full SHA for 288d78e - Browse repository at this point
Copy the full SHA 288d78eView commit details
Commits on Oct 17, 2023
-
🎨 increase fonts, improve plotting
- fixed heatmap from -1 to 1 for correlations - shrink heatmap legend :bug: greater equal, not strictly greater for cutoff
Henry committedOct 17, 2023 Configuration menu - View commit details
-
Copy full SHA for 27ba67d - Browse repository at this point
Copy the full SHA 27ba67dView commit details
Commits on Oct 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 225af4f - Browse repository at this point
Copy the full SHA 225af4fView commit details
Commits on Oct 19, 2023
-
✨ exec status script, use conda, write configs
- query torque cluster execution status changed, updated and moved - v2 of workflow now creates config files automatically which can still be used with version one - use pre-created conda environment with rule
Henry Webel committedOct 19, 2023 Configuration menu - View commit details
-
Copy full SHA for 45afa79 - Browse repository at this point
Copy the full SHA 45afa79View commit details
Commits on Oct 20, 2023
-
🎨 Snakefile_v2 ready as new default
- can create the configs needed for current workflow in Snakefile Next: Test and swap + document
Henry Webel committedOct 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 47824ce - Browse repository at this point
Copy the full SHA 47824ceView commit details -
Henry Webel committed
Oct 20, 2023 Configuration menu - View commit details
-
Copy full SHA for 464cc1c - Browse repository at this point
Copy the full SHA 464cc1cView commit details
Commits on Oct 31, 2023
-
Henry Webel committed
Oct 31, 2023 Configuration menu - View commit details
-
Copy full SHA for 345d256 - Browse repository at this point
Copy the full SHA 345d256View commit details -
🔥 move to hela_qc_mnt_data project
-> Snakefile in project folder
Henry Webel committedOct 31, 2023 Configuration menu - View commit details
-
Copy full SHA for 43aa9a1 - Browse repository at this point
Copy the full SHA 43aa9a1View commit details -
📝 add "version" to config file
- document relationship between updated and old workflow's configuration files (-> how to specify models and parameters)
Henry Webel committedOct 31, 2023 Configuration menu - View commit details
-
Copy full SHA for a358d78 - Browse repository at this point
Copy the full SHA a358d78View commit details -
🚚 move shell scripts to folder bin
Henry Webel committedOct 31, 2023 Configuration menu - View commit details
-
Copy full SHA for 801c823 - Browse repository at this point
Copy the full SHA 801c823View commit details
Commits on Nov 1, 2023
-
📝🐛 Test execution of "misc_*" notebooks
- `testNotebooks.smk` can do it. - set kernel to current environement (generic "Python 3")
Henry Webel committedNov 1, 2023 Configuration menu - View commit details
-
Copy full SHA for 51b57db - Browse repository at this point
Copy the full SHA 51b57dbView commit details -
for base workflow configuration (Snakefile vs Snakefile_v2)
Henry Webel committedNov 1, 2023 Configuration menu - View commit details
-
Copy full SHA for 500220d - Browse repository at this point
Copy the full SHA 500220dView commit details
Commits on Nov 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f46777b - Browse repository at this point
Copy the full SHA f46777bView commit details
Commits on Nov 8, 2023
-
📝 document distributed cluster execution
Henry Webel committedNov 8, 2023 Configuration menu - View commit details
-
Copy full SHA for c849cb5 - Browse repository at this point
Copy the full SHA c849cb5View commit details
Commits on Nov 9, 2023
-
Merge pull request #54 from RasmussenLab/workflow_config
Workflows update create a new version of the basic workflow allowing to run models twice with different configurations (e.g. different number of neighbours in KNN) ... while not breaking everything else For now only a new workflow is added, and the default switch will be done later. update workflow for testing all misc_* scripts execution scripts for cluster move to separate folder (and adapted to time-out after 24h) collect cluster scripts in project/bin format all Snakemake files using snakefmt
Henry Webel authoredNov 9, 2023 Configuration menu - View commit details
-
Copy full SHA for 089cc8e - Browse repository at this point
Copy the full SHA 089cc8eView commit details -
Henry committed
Nov 9, 2023 Configuration menu - View commit details
-
Copy full SHA for 26213e5 - Browse repository at this point
Copy the full SHA 26213e5View commit details -
✨ Added GSIMP and MsImpute v2-mnar
- developed locally -> up for testing if dependencies are met (GSIMP is no package and dependencies were figured out locally) - test in example workflow (-> GSimp did not finish locally)
Henry committedNov 9, 2023 Configuration menu - View commit details
-
Copy full SHA for ec85618 - Browse repository at this point
Copy the full SHA ec85618View commit details
Commits on Nov 11, 2023
-
✨ log papermill output for each job
- create individual logs for nb execution -> separate files on local execution -> documentation of how long training step took
Henry Webel committedNov 11, 2023 Configuration menu - View commit details
-
Copy full SHA for 7a55767 - Browse repository at this point
Copy the full SHA 7a55767View commit details -
🐛 None is not dumped as null without cp dict
- config dict has to be copied. Otherwise value None is not dumped as null: Before: - column_names: "None" Now: - column_names: null
Henry Webel committedNov 11, 2023 Configuration menu - View commit details
-
Copy full SHA for 8bd3211 - Browse repository at this point
Copy the full SHA 8bd3211View commit details
Commits on Nov 14, 2023
-
🐛 Quote strings to allow white spaces in folder names
Henry committedNov 14, 2023 Configuration menu - View commit details
-
Copy full SHA for d015517 - Browse repository at this point
Copy the full SHA d015517View commit details -
🐛 few features have less than 4 training observations
- one or two features have with 50 samples less than 4 intensities in training data split -> move the validation data for these to the training split
Henry committedNov 14, 2023 Configuration menu - View commit details
-
Copy full SHA for 139c792 - Browse repository at this point
Copy the full SHA 139c792View commit details
Commits on Nov 15, 2023
-
🐛 GSIMP slow, SEQKNN does not like too few features
- new dataset balancing between GSIMP runtime and SEQKNN need for a minimum number of features - run each method one by one (avoid race conditions when installing, only a problem on first time setup)
Henry committedNov 15, 2023 Configuration menu - View commit details
-
Copy full SHA for 296cbf9 - Browse repository at this point
Copy the full SHA 296cbf9View commit details
Commits on Nov 16, 2023
-
🐛 execute one-by-one, show errors in main process
Henry committedNov 16, 2023 Configuration menu - View commit details
-
Copy full SHA for 0bee424 - Browse repository at this point
Copy the full SHA 0bee424View commit details -
🐛 SeqKNN crashes with too few samples
- is GSIMP fast enough (227-> ~1h)? - probably test GSIMP here once, then remove from "fast testing" workflow
Henry committedNov 16, 2023 Configuration menu - View commit details
-
Copy full SHA for 1b23b95 - Browse repository at this point
Copy the full SHA 1b23b95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bb3d4d - Browse repository at this point
Copy the full SHA 2bb3d4dView commit details -
🐛 add method and set defaults from grid search
- update defaults to results from small grid search (smallest of top 3)
Henry Webel committedNov 16, 2023 Configuration menu - View commit details
-
Copy full SHA for 9456d91 - Browse repository at this point
Copy the full SHA 9456d91View commit details -
✨ configs for MNAR MCAR experiments
document also qsub command and update submission script
Henry Webel committedNov 16, 2023 Configuration menu - View commit details
-
Copy full SHA for 1569b97 - Browse repository at this point
Copy the full SHA 1569b97View commit details -
(add more models) - needs to be completed and cleaned-up
Henry Webel committedNov 16, 2023 Configuration menu - View commit details
-
Copy full SHA for 35322b3 - Browse repository at this point
Copy the full SHA 35322b3View commit details
Commits on Nov 17, 2023
-
Henry committed
Nov 17, 2023 Configuration menu - View commit details
-
Copy full SHA for 0b0d747 - Browse repository at this point
Copy the full SHA 0b0d747View commit details -
🐛 don't train with too small batches
- rather "bigger" batches with more training steps - update Fig. 2 plots generation to 25MNAR
Henry Webel committedNov 17, 2023 Configuration menu - View commit details
-
Copy full SHA for 89046b4 - Browse repository at this point
Copy the full SHA 89046b4View commit details
Commits on Nov 26, 2023
-
Merge pull request #55 from RasmussenLab/further_R_methods
Methods: - added GSimp. - reduced the dimensionality of the example data in the GitHub Action so GSimp finishes (~1h) -> does not scale - MNAR algorithm of MSIMPUTE added Data: - ensure that training data has at least 4 samples (MSIMPUTE includes that check) - Formatted and updated workflow configs and declarations (v1&v2). Added script for command creation
Henry Webel authoredNov 26, 2023 Configuration menu - View commit details
-
Copy full SHA for 29a549a - Browse repository at this point
Copy the full SHA 29a549aView commit details -
🎨🔧 improve swarmplots, add methods in ALD comp.
Henry committedNov 26, 2023 Configuration menu - View commit details
-
Copy full SHA for c9e00e4 - Browse repository at this point
Copy the full SHA c9e00e4View commit details -
🎨 allow custom subselection, add NA if not available
- Figure 2: add custom selection of models to aggregate best 5 models of several datasets (custom plotting for paper) - rotate performance label - add NA if model did not run (here: error or not finished within 24h)
Henry committedNov 26, 2023 Configuration menu - View commit details
-
Copy full SHA for 748a1d7 - Browse repository at this point
Copy the full SHA 748a1d7View commit details -
- for large pep and evi, the top five are already the correct set
Henry Webel committedNov 26, 2023 Configuration menu - View commit details
-
Copy full SHA for 1f2d682 - Browse repository at this point
Copy the full SHA 1f2d682View commit details
Commits on Nov 27, 2023
-
- for subselected models the colors were not reselected
Henry committedNov 27, 2023 Configuration menu - View commit details
-
Copy full SHA for e206483 - Browse repository at this point
Copy the full SHA e206483View commit details -
🎨 switch colors and show model tag for color
- based on seaborn example of _ColorPalette
Henry committedNov 27, 2023 Configuration menu - View commit details
-
Copy full SHA for e62f80b - Browse repository at this point
Copy the full SHA e62f80bView commit details -
Henry committed
Nov 27, 2023 Configuration menu - View commit details
-
Copy full SHA for db2469a - Browse repository at this point
Copy the full SHA db2469aView commit details
Commits on Nov 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 49ee8e5 - Browse repository at this point
Copy the full SHA 49ee8e5View commit details -
🎨 allow custom display name of feat
Henry committedNov 28, 2023 Configuration menu - View commit details
-
Copy full SHA for e49c1eb - Browse repository at this point
Copy the full SHA e49c1ebView commit details
Commits on Dec 5, 2023
-
🔧🎨 25MNAR share as default, update path & fontsize
- tables for Supp. Data - update plots (fontsize, support)
Henry committedDec 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 43de8bd - Browse repository at this point
Copy the full SHA 43de8bdView commit details -
🎨🔧 Update comp. with subsetted data
- use a share of 25% MNAR in removed data - use a share of 25% MNAR in comparison - update figures for publication (names, label, fontsize, etc)
Henry committedDec 5, 2023 Configuration menu - View commit details
-
Copy full SHA for bbe068e - Browse repository at this point
Copy the full SHA bbe068eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 052ed78 - Browse repository at this point
Copy the full SHA 052ed78View commit details
Commits on Dec 7, 2023
-
🎨🐛 update overfitting analysis (25MNAR)
- 🐛 remove metadata fpath from train_X.yaml - also run KNN comp. with workflow v2 with a share of 25MNAR
Henry committedDec 7, 2023 Configuration menu - View commit details
-
Copy full SHA for 49d628b - Browse repository at this point
Copy the full SHA 49d628bView commit details
Commits on Dec 12, 2023
-
📝 add three newly added methods to overview
Henry committedDec 12, 2023 Configuration menu - View commit details
-
Copy full SHA for 27d8ad2 - Browse repository at this point
Copy the full SHA 27d8ad2View commit details -
Henry committed
Dec 12, 2023 Configuration menu - View commit details
-
Copy full SHA for af85dd7 - Browse repository at this point
Copy the full SHA af85dd7View commit details