Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dataloader mask #216

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Remove the dataloader mask #216

merged 2 commits into from
Oct 6, 2023

Commits on Oct 4, 2023

  1. Remove the dataloader mask 

    Previously, when creating the dataloader, Vamb would create a mask, signifying
which contigs were unsuitable for encoding due to having no TNFs or a depth of
zeros.
However, with the recent changes in commit 5c1dc3e, sequences with zero depth
can be encoded just fine. And it was always unrealistic that a sequence would
have zero TNFs - if it did, it was probably due to a serious user mistake.
Now, do not mask sequences at all, and throw an error if a sequence has no TNFs.
    @jakobnissen
    jakobnissen committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    51a0227 View commit details
    Browse the repository at this point in the history

  2. Reformat and lint

    @jakobnissen
    jakobnissen committed Oct 4, 2023
    Configuration menu
    Copy the full SHA
    3e58511 View commit details
    Browse the repository at this point in the history