Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanup #266

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Misc cleanup #266

merged 6 commits into from
Nov 20, 2023

Conversation

jakobnissen
Copy link
Member

  • Reduce type errors
  • Add some TODOs to fix later
  • Update logging cosmetics

CC @sgalkina - I added a few TODOs in this commit. Can you look at them?

* Reduce type errors
* Add some TODOs to fix later
* Update logging cosmetics
@sgalkina
Copy link
Member

sgalkina commented Nov 17, 2023

CC @sgalkina - I added a few TODOs in this commit. Can you look at them?

I'll make those changes in a separate PR as I'll be working on the TaxVAMB code review

@sgalkina
Copy link
Member

@jakobnissen addressed the TODOs and other comments from #204 in this PR

@jakobnissen jakobnissen merged commit a7edd62 into master Nov 20, 2023
5 checks passed
@jakobnissen jakobnissen deleted the types branch November 20, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants