Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bump up version to 2.14.0 #287

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alexandru0-dev
Copy link

@alexandru0-dev alexandru0-dev commented Aug 1, 2023

WIP to bump up the version to 2.14.0

Original tree there: i3 2.14.0

Description

  • Bumping the version to the new 2.14.0 as breaking changes were introduced with the build system to maintain continuity with the original repo.

LEFT TO DO:

  • adapt github action to build and test using the new build system
  • shell completion
  • change readme and man files to suggest xss-lock
  • change background color to #a3a3a3

Release notes

Changelog of 2.14 of i3:

  • Change default background color to #a3a3a3
    See Changed background color i3/i3lock#300 for extensive
    discussion and rationale for this change.
  • Recommend using xss-lock to start i3lock in the README
    and i3lock.1 man page. xss-lock is the best way to ensure
    your screen truly is locked before your computer suspends.
  • Display modifier key warning before unlocking, too,
    not just on failed attempts like before.
  • Switch build system from autotools to meson.

Info about mod keys such as Caps Lock is now displayed
during typing, not only on failed attempt.
Original commit at i3lock: i3@deaf8b9

Signed-off-by: Alexandru Nechita <[email protected]>
WIP Migration of the build system from autotools to meson,
following the original i3lock new build system.
Original commits from i3lock:
https://github.com/i3/i3lock/tree/2.14

Signed-off-by: Alexandru Nechita <[email protected]>
@alexandru0-dev
Copy link
Author

@Raymo111 this is the draft of the new meson toolchain.

It should be already completely usable as in a drop-in-replacement.
It can be installed an uninstall using ninja install and uninstall (see install sh script).

I'm not sure how to make shell completion on meson work tho, I have found something but idk if that's is going to work as I didn't test yet, so i didn't include as the time of writing.

When you are free to can review the #286 pull request as depends on it but it can be pushed right away as it doesn't have any breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant