Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brazil and fr logos #6222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

brazil and fr logos #6222

wants to merge 1 commit into from

Conversation

tdhock
Copy link
Member

@tdhock tdhock commented Jul 5, 2024

related to #6221 and #6206
I created logos for translation teams (which are displayed, for example, on https://github.com/orgs/Rdatatable/teams/french) by putting the DT hex sticker on top of flags.
This PR adds the source SVG files along with the PNG exports to the .graphics directory.

@tdhock tdhock added the translation issues/PRs related to message translation projects label Jul 5, 2024
@tdhock tdhock self-assigned this Jul 5, 2024
@ChristianWia
Copy link

how does the logo identify that translators are concerned ? it rather identifies the french version of data.table

@tdhock
Copy link
Member Author

tdhock commented Jul 5, 2024

Hi Christian, thanks for your feedback.
My intent was for the logo to identify the target translation language.
I am not sure how to visually identify that translators are concerned. Can you clarify what you had in mind?
If you have any ideas to improve, please share and/or edit the files in this PR/branch directly.

@phgrosjean
Copy link

Thank you @tdhock. This looks nice.

@ChristianWia
Copy link

It came from "logos for translation teams ". In fact the logo is good for any one and as I said identifies the french version of data.table whatever a french data.table item is used (translation team, article, topic ...and vignette also.) . This way i understand better.. It's ok.

@leofontenelle
Copy link
Contributor

As long as the flags are used internally (and new translators are OK with them) I see no problem. More generally, though, I'd like to remember there's criticism of flags as symbols for spoken languages.

@MichaelChirico
Copy link
Member

Can you elaborate the context in which these will be used?

BTW, the non-transparent background is highlighting that the underlying logo has some weird edge behavior that looks a bit messy. Is it possible to address this?

@tdhock
Copy link
Member Author

tdhock commented Jul 9, 2024

I intended these logos to be displayed on team pages such as https://github.com/orgs/Rdatatable/teams/french
I'm not sure what you mean by the weird edge behavior, can you please clarify? For me the edges of the hexagon look black.

@MichaelChirico
Copy link
Member

I intended these logos to be displayed on team pages such as https://github.com/orgs/Rdatatable/teams/french

Sounds great

I'm not sure what you mean by the weird edge behavior, can you please clarify?

image

Yes, I mean these transitional parts along the non-linear border of the seal

@tdhock
Copy link
Member Author

tdhock commented Jul 9, 2024

ok thanks for clarifying. those white edges along the whiskers and body of the seal are indeed present in the original logo. so we should try to fix that here before merging.

@MichaelChirico
Copy link
Member

we should try to fix that here before merging.

FWIW, I see the logos already added to the teams page & the compression there hides these issues. So we could earmark it for a future improvement. Either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation issues/PRs related to message translation projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants