-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brazil and fr logos #6222
base: master
Are you sure you want to change the base?
brazil and fr logos #6222
Conversation
how does the logo identify that translators are concerned ? it rather identifies the french version of data.table |
Hi Christian, thanks for your feedback. |
Thank you @tdhock. This looks nice. |
It came from "logos for translation teams ". In fact the logo is good for any one and as I said identifies the french version of data.table whatever a french data.table item is used (translation team, article, topic ...and vignette also.) . This way i understand better.. It's ok. |
As long as the flags are used internally (and new translators are OK with them) I see no problem. More generally, though, I'd like to remember there's criticism of flags as symbols for spoken languages. |
Can you elaborate the context in which these will be used? BTW, the non-transparent background is highlighting that the underlying logo has some weird edge behavior that looks a bit messy. Is it possible to address this? |
I intended these logos to be displayed on team pages such as https://github.com/orgs/Rdatatable/teams/french |
Sounds great
Yes, I mean these transitional parts along the non-linear border of the seal |
ok thanks for clarifying. those white edges along the whiskers and body of the seal are indeed present in the original logo. so we should try to fix that here before merging. |
FWIW, I see the logos already added to the teams page & the compression there hides these issues. So we could earmark it for a future improvement. Either way. |
related to #6221 and #6206
I created logos for translation teams (which are displayed, for example, on https://github.com/orgs/Rdatatable/teams/french) by putting the DT hex sticker on top of flags.
This PR adds the source SVG files along with the PNG exports to the .graphics directory.