add one level of additional revdeps to mirror packages in CI #6230
Conversation
.ci/ci.R
Outdated
| local.extract_dependency_package_names = function (x) { | ||
| ## do not filter out R like tools:::.extract_dependency_package_names, used for web/$pkg/index.html | ||
| if (is.na(x)) | ||
| return(character()) | ||
| x <- unlist(strsplit(x, ",[[:space:]]*")) | ||
| x <- sub("[[:space:]]*([[:alnum:].]+).*", "\\1", x) | ||
| x[nzchar(x)] | ||
| } | ||
|
|
||
| rev.dependencies = function(pkg, available_pkgs, which=c("Imports", "Depends")) { | ||
| dependencies = available_pkgs[pkg, which] | ||
| x = dependencies[!is.na(dependencies)] |
There was a problem hiding this comment.
here can you please insert a comment explaining why tools::dependsOnPkgs is not sufficient?
There was a problem hiding this comment.
Maybe I misunderstood something but tools:dependsOnPkgs(x) shows the relation for results depends on x (and only does so for installed packages). However, we want the inverse with x depends/imports result.
There was a problem hiding this comment.
only does so for installed packages
This part is easy to overcome: tools::dependsOnPkgs("data.table", installed=available.packages()).
Anyway, you're correct that's going in the wrong direction; tools::package_dependencies() traverses the graph in the right direction:
tools::package_dependencies("data.table", recursive=TRUE, which="all") # overkill
# second-level instead
tools::package_dependencies("data.table", which="all") |>
unlist() |> tools::package_dependencies() |> # could use which="all" here too?
unlist(use.names=FALSE) |> setdiff(tools:::.get_standard_package_names()$base)
|
does "mirroring" mean that the ci will keep a copy of these packages between runs, rather than downloading them in each run? |
Exactly |
Currently we already mirror reverse dependencies, but these might also have reverse dependencies etc.
This results in that our CI reports things like
also installing the dependencies ‘R.oo’, ‘R.methodsS3’, ‘evaluate’, ‘highr’, ‘xfun’, ‘commonmark’This PR adds one extra level of mirroring also the
c("Imports", "Depends")of the mirrored reverse dependencies (no recursion yet).