-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated French .po files #6775
base: master
Are you sure you want to change the base?
Updated French .po files #6775
Conversation
This reverts commit f075acf.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6775 +/- ##
==========================================
+ Coverage 98.60% 98.64% +0.03%
==========================================
Files 79 79
Lines 14641 14640 -1
==========================================
+ Hits 14437 14441 +4
+ Misses 204 199 -5 ☔ View full report in Codecov by Sentry. |
@@ -73,16 +76,17 @@ msgstr "Utiliser 'key' ou 'sorted' mais pas les deux simultanément." | |||
|
|||
#: as.data.table.R:108 | |||
#, c-format | |||
msgid "Argument 'value.name' should not overlap with column names in result: %s" | |||
msgid "" | |||
"Argument 'value.name' should not overlap with column names in result: %s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like there are a lot of changes that add new lines / line breaks that do not actually affect the translated string, is that expected / desirable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's definitely not desirable! However, it is expected.
I think both files are currently "incorrect", but the new file at least matches the others.
Here's the profile of line widths of R-fr.po on master
vs. this updated branch:
table(nchar(readLines('po/R-fr.po')))
# MASTER
0 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26
484 1 1 1 3 4 212 274 10 507 50 63 104 43 22 35 14 79 107 13 9 8 25 12 5
27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51
15 14 12 7 11 5 6 8 14 17 8 11 11 23 11 20 12 12 10 17 15 14 17 10 12
52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76
17 17 20 15 19 11 12 15 23 15 15 23 21 23 15 18 16 21 16 21 33 45 61 69 82
77 78 79 80 81
100 121 138 174 131
# THIS BRANCH
0 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27
618 2 5 3 8 260 405 15 527 74 75 111 77 31 39 39 87 136 16 17 12 49 15 8 15
28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52
14 16 11 14 10 10 9 20 18 15 17 22 27 17 27 17 18 14 24 17 20 15 17 11 24
53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77
17 22 24 22 11 11 15 24 22 16 24 24 29 20 21 23 32 28 41 64 76 101 130 140 188
78 79
180 164
I think exactly 80 is the intended width, currently it's exactly 79 :|
c.f. also the other languages' .po files:
po_files = list.files("po", pattern="[^r][.]po$", full.names=TRUE) # exclude fr
table(unlist(lapply(po_files, \(f) nchar(readLines(f)))))
0 1 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
3357 4 2 34 12 20 39 1414 1451 92 2682 162 376 638 1117 329 291 156 262 405
21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40
75 85 72 122 106 84 105 138 87 101 106 80 109 105 138 133 95 109 119 146
41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60
157 148 122 114 137 130 140 130 148 138 114 133 115 144 129 139 100 97 128 117
61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
130 93 127 106 103 112 104 94 142 155 193 280 328 377 466 575 667 666 672
So this change brings *fr.po in line with the others, at least.
ok that's fine, just wanted to check |
Thanks in advance!