feat: Improve shorts remove key and using tqdm for progress #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indrastorms
force-pushed
the
feat-async-runner
branch
from
90d769e
to
5333971
Compare
indrastorms
changed the title
oSumAtrIX
reviewed
Mar 10, 2024
oSumAtrIX
requested changes
Mar 10, 2024
|
@alexandreteles I am not sure if opening a file handle everytime is done correctly here. |
This reverts commit 10927bb.
The async file handler deals with that. We could also open a single handler and share between the workers but that will require writing extra logic which |
indrastorms
changed the title
alexandreteles
approved these changes
Mar 12, 2024
|
Please update the requirement file with tqdm. I don't have poetry installed 😅 |
I will first merge the other changes and then investigate this one again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing already marked watched beforehand can increase the perf. Changing "#short" to "short" because some title has #ytshorts