fix(Lightroom): Add `Disable version check` patch #6315

f1re4xx · 2025-11-24T17:39:58Z

This PR introduces a new patch for Adobe Lightroom named Disable version check.

It specifically targets version 9.3.0 to bypass the application's startup validation, which prevents the app from opening if the version is deemed "denylisted" or below the minimum requirement by the server.

Fingerprint: Locates the public static method responsible for fetching the version status (references denylisted_version_set_key and app_min_version_key).

Patch Logic:

Identifies the IGET opcode that retrieves the version status.
Injects const/4 v1, -0x2 immediately after the fetch.
This overwrites the actual server check result with -0x2, effectively bypassing the check.

API: Updated patches.api to expose the new DisableVersionCheckPatch

oSumAtrIX · 2025-11-24T17:43:05Z

...in/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt

+
+@Suppress("unused")
+val disableVersionCheckPatch = bytecodePatch(
+    name = "Disable version check",


Add a description with the purpose of the patch

description added

oSumAtrIX · 2025-11-24T17:43:59Z

...in/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt

the patch can be directly placed in misc package. The file name should start with uppercase

I placed it similarly to the two existing patches

I am not sure but the file still seems in the wrong package

The package name should be lowercase "versioncheck" for example

oSumAtrIX · 2025-11-24T17:44:42Z

patches/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt

+        Opcode.INVOKE_STATIC,       // invoke-static {}, Lbf/p;->b()Lbf/p$a;
+        Opcode.MOVE_RESULT_OBJECT,  // move-result-object v0
+        Opcode.IGET,                // iget v1, v0, Lbf/p$a;->a:I  <-- TARGET
+        Opcode.CONST_4,             // const/4 v2, -0x2
+        Opcode.CONST_STRING,        // const-string v3...
+        Opcode.CONST_STRING,        // const-string v4...
+        Opcode.IF_NE                // if-ne v1, v2, :cond_0


Instead of commenting code like this, say how you want to change the specific instruction, e.g "Overwrite this."

oSumAtrIX · 2025-11-24T17:46:41Z

patches/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt

+        Opcode.INVOKE_STATIC,       // invoke-static {}, Lbf/p;->b()Lbf/p$a;
+        Opcode.MOVE_RESULT_OBJECT,  // move-result-object v0
+        Opcode.IGET,                // iget v1, v0, Lbf/p$a;->a:I  <-- TARGET
+        Opcode.CONST_4,             // const/4 v2, -0x2
+        Opcode.CONST_STRING,        // const-string v3...
+        Opcode.CONST_STRING,        // const-string v4...
+        Opcode.IF_NE                // if-ne v1, v2, :cond_0


Can the pattern be made shorter?

Simplified, seems to work fine

patches/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt

oSumAtrIX · 2025-11-24T18:04:49Z

...in/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt

+
+    execute {
+        versionCheckFingerprint.method.apply {
+            val igetIndex = implementation!!.instructions.indexOfFirst {


Instead of this, use versionCheckFingerprint.patternMatch.endIndex

patches/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt

oSumAtrIX · 2025-11-24T18:05:52Z

...in/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt

+            }
+
+            if (igetIndex != -1) {
+                addInstruction(igetIndex + 1, "const/4 v1, -0x2")


Whats -0x2? Add a comment or use a named val to avoid magic constants.

oSumAtrIX · 2025-11-24T18:06:10Z

...in/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt

+            }
+
+            if (igetIndex != -1) {
+                addInstruction(igetIndex + 1, "const/4 v1, -0x2")


You can use "replaceInstruction instead of add

oSumAtrIX · 2025-11-24T18:06:33Z

patches/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt

+import com.android.tools.smali.dexlib2.AccessFlags
+import com.android.tools.smali.dexlib2.Opcode
+
+internal val versionCheckFingerprint = fingerprint {


Is the name ideal for the fingerprint? Is the method it matches a "checkVersion()" method?

I'm not sure, as decompiling this gives a single letter method name. I assumed it's a valid name given what this patch does.

Try to infer from the methods implementation

Is refreshRemoteConfigurationFingerprint better? This method seems to load a current config from remote servers and save it to the app's storage.

sure, or simpler saveRemoteConfigurationFingerprint or fetchRemoteConfigurationFingerprint

…passVersionCheck/Fingerprints.kt

...in/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt

patches/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt

oSumAtrIX

Last issue, then lgtm https://github.com/ReVanced/revanced-patches/pull/6315/files#r2557189697

...in/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt

f1re4xx mentioned this pull request Nov 24, 2025

bug: [Lightroom] Version 9.3.0 Can no longer be used. #6310

Open

3 tasks

oSumAtrIX self-requested a review November 24, 2025 17:42

oSumAtrIX reviewed Nov 24, 2025

View reviewed changes

fix: lightroom version bypass patch (allow 9.3.0 to open)

10cc62d

oSumAtrIX changed the base branch from main to dev November 24, 2025 17:54

oSumAtrIX changed the title ~~fix(lightroom): add disable version check patch~~ fix(Lightroom): Add Disable version check patch Nov 24, 2025

fix: [lightroom patch] add patch description, simplify fingerprint

aba800c

f1re4xx force-pushed the main branch from c875cc0 to aba800c Compare November 24, 2025 18:01

oSumAtrIX reviewed Nov 24, 2025

View reviewed changes

patches/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt Outdated Show resolved Hide resolved

oSumAtrIX reviewed Nov 24, 2025

View reviewed changes

patches/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt Outdated Show resolved Hide resolved

oSumAtrIX reviewed Nov 24, 2025

View reviewed changes

patches/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt Outdated Show resolved Hide resolved

oSumAtrIX reviewed Nov 24, 2025

View reviewed changes

oSumAtrIX and others added 4 commits November 24, 2025 19:06

Apply suggestion from @oSumAtrIX

f2ea6c6

Update patches/src/main/kotlin/app/revanced/patches/lightroom/misc/by…

1ac1e5f

…passVersionCheck/Fingerprints.kt

fix: [lightroom patch] make implementation more clear

f3b10dd

fix: [lightroom patch] rename fingerprint

1db0507

oSumAtrIX reviewed Nov 25, 2025

View reviewed changes

...in/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt Outdated Show resolved Hide resolved

oSumAtrIX reviewed Nov 25, 2025

View reviewed changes

...in/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt Outdated Show resolved Hide resolved

oSumAtrIX reviewed Nov 25, 2025

View reviewed changes

patches/src/main/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/Fingerprints.kt Show resolved Hide resolved

Apply suggestions from code review

6d3506c

oSumAtrIX requested changes Nov 25, 2025

View reviewed changes

fix: [lightroom patch] add description to DisableVersionCheck

ab6c85c

oSumAtrIX reviewed Dec 3, 2025

View reviewed changes

...in/kotlin/app/revanced/patches/lightroom/misc/bypassVersionCheck/DisableVersionCheckPatch.kt Outdated Show resolved Hide resolved

Apply suggestion from @oSumAtrIX

b882a33

Uh oh!

fix(Lightroom): Add Disable version check patch #6315

Are you sure you want to change the base?

fix(Lightroom): Add Disable version check patch #6315

Conversation

f1re4xx commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

f1re4xx Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oSumAtrIX Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

oSumAtrIX left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(Lightroom): Add `Disable version check` patch #6315

fix(Lightroom): Add `Disable version check` patch #6315

f1re4xx commented Nov 24, 2025 •

edited

Loading

f1re4xx Nov 25, 2025 •

edited

Loading

oSumAtrIX Nov 24, 2025 •

edited

Loading